Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 270624 - NPE in FeatureManifestParser
Summary: NPE in FeatureManifestParser
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-31 11:30 EDT by Matthew Piggott CLA
Modified: 2009-03-31 14:34 EDT (History)
1 user (show)

See Also:


Attachments
FeatureManifestParser (1.08 KB, patch)
2009-03-31 11:30 EDT, Matthew Piggott CLA
pascal: iplog+
Details | Diff
/org.eclipse.equinox.p2.tests/testData/updatesite/digest/digest.zip (349 bytes, application/zip)
2009-03-31 11:37 EDT, Matthew Piggott CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Piggott CLA 2009-03-31 11:30:54 EDT
Created attachment 130402 [details]
FeatureManifestParser

An NPE can occur while parsing an update site digest which contains localized strings.  This occurs because the method parse() is not called and the list messageKeys is not initialized.
Comment 1 Matthew Piggott CLA 2009-03-31 11:37:10 EDT
Created attachment 130404 [details]
/org.eclipse.equinox.p2.tests/testData/updatesite/digest/digest.zip

I've changed one of the attributes in this digest used by another test to contain a localized string.

I ran into the problem using the update site at:
   http://download.eclipse.org/releases/ganymede/ 
(a p2 repository co-habitats the location so place a breakpoint in AbstractRepositoryManager#loadRepository() and change the order of the suffixes to check for an updateSite first.)
Comment 2 Pascal Rapicault CLA 2009-03-31 14:34:52 EDT
Fixed in HEAD.