Community
Participate
Working Groups
The current syntax coloring is pretty picky on what it expects to be done. This needs to be improved, so that NPE's are not being tossed, and wider range of XQuery samples needs to be run through the code. Also, might have to run the Antlr runtime generator against the XQuery grammar provided by Martin Probst in XQpretty, so that it can be used with a released version of the Antlr Runtime.
New XQuery code still doesn't allow for configuration of Syntax colors.
We definitely have agreement that the colors should be configurable. I'd like to support color profiles, possibly with export/import. I don't know if this is a feature available in other plugins that we might be able to leverage. I also think the default colors need some work; to the extent we're in conflict with XML coloring in other Eclipse editors, we should correct that. For XQuery constructs though, color combinations like yellow on white just aren't readable. What do you mean with the XQuery grammar comment David? I do think our grammar has some issues, but it also contains vendor extensions, so if you're suggesting that we use an existing standard-based grammar, I don't think that will work. Perhaps that comment is just dated?
(In reply to comment #2) > What do you mean with the XQuery grammar comment David? I do think our grammar > has some issues, but it also contains vendor extensions, so if you're > suggesting that we use an existing standard-based grammar, I don't think that > will work. Perhaps that comment is just dated? The old XQuery editor code still in org.eclipse.wst.xquery, used an old grammar from a third party which we didn't have control over. It was hit or miss at times if we were detecting keywords correctly that needed to be colored. So, yes the comment is out dated.
Should be implemented for 0.7 M1
Wrong priority!
You might want to take a look at: AbstractScriptEditorColoringConfigurationBlock
The SSE provides this feature (even though no sample document is provided). I suggest we close this bug.
(In reply to comment #7) > The SSE provides this feature (even though no sample document is provided). > > I suggest we close this bug. Is this completely working now? I haven't yet tried.
Also would like to see Unit Tests to verify that this is working. If preferences stored are changed are the new values in affect. In general the plugins need more unit tests.
It's working but it is not integrated with the XML coloring preference page. That could be another enhancement request. What tools are used to write UI tests?
Junit as you are really testing the result of the values of the syntax coloring at specific regions. Take a look at the org.eclipse.wst.xsl.ui.tests plugin for some examples.
This bug is now obsolete as the main feature is there in the SSE editor. Create bugs: Bug 321720 for unit testing Bug 321723 for color scheme enhancement
