Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 270395 - [UI] Should use asyncExec instead of syncExec when calling the display
Summary: [UI] Should use asyncExec instead of syncExec when calling the display
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.ui (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: M6   Edit
Assignee: Victor Roldan Betancort CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-29 15:42 EDT by Simon Mc Duff CLA
Modified: 2010-06-29 04:18 EDT (History)
3 users (show)

See Also:
stepper: galileo+
stepper: review+

Attachments
patch v1 (11.42 KB, patch)
2009-03-30 07:16 EDT, Victor Roldan Betancort CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Mc Duff CLA 2009-03-29 15:42:11 EDT 
The UI uses syncExec at many places. This could be a problem when CDO framework is calling handler such as CDOTransactionHandler.

It is also a best practice to use asyncExec!!
Comment 1 Victor Roldan Betancort CLA 2009-03-30 05:58:02 EDT 
Stepháne, I believe this concerns you :P
Comment 2 Victor Roldan Betancort CLA 2009-03-30 07:16:18 EDT 
Created attachment 130224 [details]
patch v1

- changed all syncExec calls, except those that popup a dialog (just one).
- Merged with disposed container issue.
Comment 3 Simon Mc Duff CLA 2009-03-30 21:54:45 EDT 
Without this patch it is really hard to use the CDOEditor without having deadlock!!
Comment 4 Eike Stepper CLA 2009-03-31 01:51:38 EDT 
Well done ;-)
Comment 5 Victor Roldan Betancort CLA 2009-03-31 07:40:36 EDT 
Committed to HEAD
Comment 6 Eike Stepper CLA 2009-04-02 17:35:03 EDT 
Fix available in EMF CDO 2.0.0M6b
Comment 7 Eike Stepper CLA 2009-06-27 11:49:53 EDT 
Generally available.