270332 – put() is called twice for DocShares due to ECF Generic group handling

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 270332 - put() is called twice for DocShares due to ECF Generic group handling

Summary: put() is called twice for DocShares due to ECF Generic group handling

Status:	RESOLVED FIXED

Alias:	None

Product:	ECF
Classification:	RT
Component:	ecf.cola (show other bugs)
Version:	3.0.0
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	3.0.0RC2
Assignee:	Remy Suen
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2009-03-27 17:20 EDT by Nitin Dahyabhai
Modified:	2009-05-15 14:28 EDT (History)
CC List:	4 users (show)

See Also:

Flags:	slewis: review+ mayworm: review+

Attachments
proposed patch (1.01 KB, patch) 2009-03-27 17:20 EDT, Nitin Dahyabhai	remy.suen: iplog+	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nitin Dahyabhai

2009-03-27 17:20:34 EDT

Created attachment 130146 [details]
proposed patch

v2009032-0800

Remy found that the subject Hashtable never has put() called on it, meaning there's no adding of docshare channels for reference later.  This causes strange problems fixed with the attached patch.

Comment 1 Remy Suen

2009-03-27 19:16:28 EDT

(In reply to comment #0)
> Remy found that the subject Hashtable never has put() called on it, meaning
> there's no adding of docshare channels for reference later.  This causes
> strange problems fixed with the attached patch.

The problem is it gets called twice actually. See bug 256971 for details.

Comment 2 Scott Lewis

2009-05-12 18:59:27 EDT

Setting target milestone and assigning to Remy.  Remy please reassign if necessary.

Comment 3 Remy Suen

2009-05-14 11:18:43 EDT

(In reply to comment #0)
> Created an attachment (id=130146) [details]
> proposed patch

This looks fine to me.

Comment 4 Remy Suen

2009-05-14 11:19:26 EDT

Adding Scott and Marcelo for review.

Comment 5 Scott Lewis

2009-05-14 12:10:48 EDT

+1 for the proposed patch.

Comment 6 Marcelo Mayworm

2009-05-14 16:18:17 EDT

for me +1 too

Comment 7 Remy Suen

2009-05-14 16:40:15 EDT

Thanks Scott, Marcelo, and Nitin.

Fix released to HEAD (along with license header updates). I also corrected the bug summary.

Comment 8 Remy Suen

2009-05-14 16:41:10 EDT

(In reply to comment #6)
> for me +1 too

Just noticed, for completeness's sake, Marcelo, the + is supposed to go in the 'Flags' box below the 'People' box (in the web UI). I don't know how this looks in Mylyn if you're using Mylyn.