Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 269814 - [working sets] 'Assign Working Set...' in Package Explorer with 'Top Level Elements > Projects' shows invalid UI element
Summary: [working sets] 'Assign Working Set...' in Package Explorer with 'Top Level El...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Raksha Vasisht CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-24 08:11 EDT by Dani Megert CLA
Modified: 2009-04-29 04:21 EDT (History)
0 users

See Also:

Attachments
Patch with the fix. (1.30 KB, patch)
2009-03-25 07:39 EDT, Raksha Vasisht CLA 		daniel_megert: review-
Details | Diff
Patch with added null check. (1.44 KB, patch)
2009-03-26 08:38 EDT, Raksha Vasisht CLA 		daniel_megert: iplog+
daniel_megert: review+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2009-03-24 08:11:56 EDT 
I20090317-1745.

1. choose 'Top Level Elements > Working Sets'
2. choose 'Top Level Elements > Projects'
3. 'Assign Working Set...' 
==> it shows invalid 'Show only Package Explorer working sets' check box which is not applicable
Comment 1 Dani Megert CLA 2009-03-25 04:48:49 EDT 
This is broken for quite a while.
Comment 2 Raksha Vasisht CLA 2009-03-25 07:39:09 EDT 
Created attachment 129831 [details]
Patch with the fix.

The model is set once the top level elements are set to working sets.So it no longer is null even if switched to top level elements as projects. Added check for top level elements to be projects in the viewer filter to disable the check box and the hyperlink to configure working sets in the dialog but still show all the working sets in the viewer.
Comment 3 Dani Megert CLA 2009-03-26 07:10:29 EDT 
Comment on attachment 129831 [details]
Patch with the fix.

Patch is almost good, except that getActivePackageExplorer() can be null.
Comment 4 Raksha Vasisht CLA 2009-03-26 08:38:35 EDT 
Created attachment 129956 [details]
Patch with  added null check.
Comment 5 Dani Megert CLA 2009-03-26 10:07:03 EDT 
Patch is good.

Committed to HEAD.
Available in builds > N20090325-2000.
Comment 6 Dani Megert CLA 2009-04-29 04:21:59 EDT 
Verified in I20090428-0100.