Community
Participate
Working Groups
I haven't java.exe at PATH so in eclipse.ini file I add parameters like this: -vm c:/jdk1.5.0_17/bin Then I (un)install plugins from update site and at Software Updates dialog push Yes button. But Eclipse doesn't start because parameter is changed to -vm file:/c:/jdk1.5.0_17/bin
Which eclipse build are you using? What were you installing / updating?
Sorry, 3.5 M6 I'm working with own simple plugin which have update site.
The target milestone is used to indicate an expected date for fixing the bug. 3.5 M6 is over :)
Created attachment 129609 [details] FileUtils patch It looks like this was caused by FileUtils.toPath, it attempts to verify that the URI refers to a file. Unfortunately it was comparing the URI's scheme to file protocol (file:) rather than the file scheme (file) which would always return false. I wasn't able to replicate this directly, but experimentation with the calls made in EclipseLauncherParse.setVM() seems to indicate that this would only occur on Windows when Eclipse and the VM are on different drives.
Yes, VM installed at drive C: but eclipse at D:
If I have VM and eclipse installed at same drive (c:\jdk1.5.0_17 and c:\ECLIPSE35M6) there is another result: -vm ../jdk1.5.0_17/bin Maybe keeping this argument unchanged is the best way?
(In reply to comment #6) > If I have VM and eclipse installed at same drive (c:\jdk1.5.0_17 and > c:\ECLIPSE35M6) there is another result: > -vm > ../jdk1.5.0_17/bin > Maybe keeping this argument unchanged is the best way? > Right. The location was changed to relative path, does it still fail to load at that point?
No, in case same drive location it works. But changing value confused me.
*** Bug 270353 has been marked as a duplicate of this bug. ***
We need to only the relativize when the VM is located in the install folder.
(In reply to comment #10) > We need to only the relativize when the VM is located in the install folder. > Sorry, don't understand the logic of this. As pointed out in Bug 270353, relative paths do have a distinct draw-back and, further, conversion to a relative path is a regression relative to prior Eclipse versions. Eclipse really should not convert an absolute path to relative, even if the VM and Eclipse installation are on the same drive. Not sure this is relevant, but at least on Windows, using the autorestart after updating Eclipse or using File->Restart will not result in Eclipse failing to start -- as if Eclipse is using an un-modified cached copy of the eclipse.ini. Rather, it will be first encountered on a cold restart of Eclipse.
the case I'm talking about is: c:/eclipse c:/eclipse/vm/jre In this case you probably prefer having the path being kept relative.
(In reply to comment #12) > the case I'm talking about is: > c:/eclipse > c:/eclipse/vm/jre > > In this case you probably prefer having the path being kept relative. > Actually, no. I am rather certain that if I put an absolute path to the VM in the eclipse.ini, then I intend it to be an absolute path -- quite regardless of the relative locations of the eclipse installation and VM -- and that I prefer to keep it just that way. I must be missing something. Is there an overriding reason for Eclipse to presume and force a relative path over a user defined absolute path? Thanks...
The problem is that internally fwk admin only reason in fully qualified paths (and we currently don't remember the original value specified) and the value accepted when setting is also a fully qualified path. However there are still cases where the user intend to have a relative path and this is when everything is co-located (the vm is within the eclipse install therefore moving eclipse around will move the vm as well). In the past we had a case where we were writing everything in absolute and it broke this case.
I'm sorry, but I don't understand the most recent comment above. What is the reason that eclipse.ini is changed in the first place? I agree 100% with comment 13 that when I put an absolute path in eclipse.ini I expect it to stay that way. In my opinion there should be NO circumstance where it is changed without my explicit approval or action.
Created attachment 130280 [details] Relativization change & FileUtils bugfix The change should only relativize JRE locations which are under the Eclipse directory.
Fixed in HEAD.
Created attachment 130763 [details] Windows test case fix Fixes a slight problem with a test case on windows.
Thanks Matt, I have released your additional fix to HEAD.
