This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 269404 - Navigator improvements should be brought to the CNF and its extensions
Summary: Navigator improvements should be brought to the CNF and its extensions
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 0.9   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.9 RC1   Edit
Assignee: Serge Beauchamp CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 267349 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-03-19 12:09 EDT by Serge Beauchamp CLA
Modified: 2010-03-12 09:51 EST (History)
4 users (show)

See Also:


Attachments
Support for e4 resource semantics (groups and linked resources) (8.64 KB, patch)
2009-05-01 09:36 EDT, Serge Beauchamp CLA
no flags Details | Diff
Hack to the CNF to make the CNF resource DND assistant have precedence (2.16 KB, patch)
2009-05-01 09:38 EDT, Serge Beauchamp CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Serge Beauchamp CLA 2009-03-19 12:09:31 EDT
The e4 resource improvements brought many drag and drop improvements to the navigator view (see "Drag and Drop auto-generation of linked resources ") in the following post for an illustration of one of the improvements http://sergebeauchamp.blogspot.com/2009/01/latest-e4-resource-changes.html.

The improvements include:

- Automatically converting the copy/move semantic to create link/groups when the drop target is a group.

- Optionally displaying a dialog to import a hierarchy of files in folders from the file system into a file structure of linked resources and groups.

In order to bring those improvements to the JDT and CDT navigator view, the Common Navigator Framework should be improve so that it provides the necessary common code to support the e4 resource drag and drop improvements.
Comment 1 James Blackburn CLA 2009-03-19 12:32:49 EDT
*** Bug 267349 has been marked as a duplicate of this bug. ***
Comment 2 Serge Beauchamp CLA 2009-05-01 09:36:33 EDT
Created attachment 134057 [details]
Support for e4 resource semantics (groups and linked resources)

Here is the patch that adds the ui.ide navigator features to the CNF.  

This patch is not sufficient, though, because it misses a mechanism to select the common navigator resource drop assistant over other assistant that conflict over the same resources (namely the JDT).

For debugging purposes, I handle that with a small hack in the CNF DNDService that always asks the CNF resource assistant first, but this is not obviously not the proper way to fix it.

One solution would be for the JDT to stop handling cases that are already supported by the CNF resource assistant.

Another solution, more general and appropriate, would be to have some kind of automatic conflict resolution mechanism, since this problem is likely to happen when more and more clients are using the CNF.
Comment 3 Serge Beauchamp CLA 2009-05-01 09:38:25 EDT
Created attachment 134058 [details]
Hack to the CNF to make the CNF resource DND assistant have precedence

Hack to the CNF to make the CNF resource DND assistant have precedence Hack to the CNF to make the CNF resource DND assistant have precedence
Comment 4 Serge Beauchamp CLA 2009-05-01 09:43:01 EDT
Anyone know how to either add Francis Upton - the CNF lead- to this bug (I don't have his email), or add this bug to the CNF "bucket"?
Comment 5 Serge Beauchamp CLA 2009-05-01 11:43:03 EDT
Adding Francis to get his comments on how to resolve dnd assistant conflicts.
Comment 6 Serge Beauchamp CLA 2009-07-14 16:33:34 EDT
Patch now integrated in e4 as of v20090716-1930.
Comment 7 Serge Beauchamp CLA 2010-03-12 09:51:43 EST
fixed in I20100311-1616