Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 268937 - [Net] Native entries on "Network Connection" page should be refreshed more often
Summary: [Net] Native entries on "Network Connection" page should be refreshed more often
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-17 06:02 EDT by Szymon Brandys CLA
Modified: 2010-09-20 04:04 EDT (History)
1 user (show)

See Also:
Szymon.Brandys: review+


Attachments
initial patch (7.70 KB, patch)
2010-08-25 09:50 EDT, Wojciech Galanciak CLA
no flags Details | Diff
patch without changes in UI (4.58 KB, patch)
2010-09-13 06:55 EDT, Wojciech Galanciak CLA
no flags Details | Diff
fix (5.50 KB, patch)
2010-09-16 05:52 EDT, Wojciech Galanciak CLA
no flags Details | Diff
fix (6.38 KB, patch)
2010-09-16 06:02 EDT, Wojciech Galanciak CLA
Szymon.Brandys: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2009-03-17 06:02:45 EDT
Go to "Preferences > Network Connections". If OS proxy is not set and active provider is set to "Native", you'll see only manual entries.

Now if you change OS settings (e.g. IE proxy settings on Windows), the table on Network Connections page will not reflect those changes, even if you click "Apply". You have to reopen the dialog to see changes. This can be confusing for users.

I think that users should be aware of the fact that native entries can be not in sync with real OS proxy settings (maybe a prompt) and either refresh those entries periodically or add a button to refresh them.
Comment 1 Wojciech Galanciak CLA 2010-08-25 09:50:16 EDT
Created attachment 177420 [details]
initial patch

Here is a patch which adds new refresh button (position can be different) which refreshes native proxy settings. Szymon, what do you think about that solution?
Comment 2 Pawel Pogorzelski CLA 2010-09-07 06:37:52 EDT
Couldn't we just refresh the values when processing "Apply" and when the page is turned visible (when user switches between nodes)? The button would be only applicable to OS entries and for another providers it would clatter the UI.
Comment 3 Wojciech Galanciak CLA 2010-09-07 08:46:04 EDT
Button is one of Szymon's idea so I decided to go in this direction. I think that it should be always applicable cause its purpose is to inform user what are current non-manual settings (even if a current provider is different than native). However, I think that it is a good idea to remove it and refresh list only after pressing Apply or/and changing provider.
Comment 4 Wojciech Galanciak CLA 2010-09-13 06:55:35 EDT
Created attachment 178731 [details]
patch without changes in UI

Here is a patch which does not change anything in UI. Proxy settings are refreshed when provider is changed or preferences are applied (as Pawe³ suggested).
Comment 5 Wojciech Galanciak CLA 2010-09-16 05:52:13 EDT
Created attachment 179010 [details]
fix

Updated patch without UI changes.
Comment 6 Wojciech Galanciak CLA 2010-09-16 06:02:55 EDT
Created attachment 179016 [details]
fix
Comment 7 Szymon Brandys CLA 2010-09-16 06:23:08 EDT
Looks good.
Comment 8 Szymon Brandys CLA 2010-09-20 04:02:57 EDT
Checked in to HEAD.