Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 268819 - [WorkbenchLauncher] 'Workspaces' preference page's 'Remove' button should enable/disable itself more intelligently
Summary: [WorkbenchLauncher] 'Workspaces' preference page's 'Remove' button should ena...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Boris Bokowski CLA
QA Contact: Boris Bokowski CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-16 11:45 EDT by Remy Suen CLA
Modified: 2009-04-28 16:45 EDT (History)
1 user (show)

See Also:

Attachments
Patch against org.eclipse.ui.ide.application (1.31 KB, patch)
2009-03-20 10:14 EDT, Eric Rizzo CLA 		bokowski: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2009-03-16 11:45:50 EDT 
1. Window > Preferences > General > Startup > Workspaces
2. Select a workspace.
3. Click 'Remove'.
4. There is now no selection, but the 'Remove' button is still enabled.
Comment 1 Boris Bokowski CLA 2009-03-19 18:40:47 EDT 
Hi Eric, would you be able to work on this?
Comment 2 Eric Rizzo CLA 2009-03-20 08:41:34 EDT 
Sure. I thought I had tested that, but apparently not enough. Maybe it's time to learn to use SWTBot...
Comment 3 Eric Rizzo CLA 2009-03-20 10:14:22 EDT 
Created attachment 129455 [details]
Patch against org.eclipse.ui.ide.application

This patch fixes the enablement behavior of the Remove button.
Comment 4 Boris Bokowski CLA 2009-03-20 14:44:13 EDT 
Thanks!
Comment 5 Boris Bokowski CLA 2009-04-24 12:00:03 EDT 
Fix released to HEAD.
Comment 6 Boris Bokowski CLA 2009-04-28 16:45:22 EDT 
Verified using I20090428-0100.