Description Stefan Riesen 2009-03-14 23:04:13 EDT

Created attachment 128835 [details]
Patch to resolve the javascript bug

Build ID: M20080911-1700

Steps To Reproduce:
1. Have a Browser with enables pop-up-blocker
2. Use ExternalBrowser.open(...) to open a External Page


More information:
The Bug has been found using Safari 4 Beta on OS X with enabled pop-up-blocker.

The javascript part with the typo is:

  open : function( id, url, features ) {
      var win = window.open( url, id, features, true );
      if( win !== null ) {
        win.focus();
        org.eclipse.rwt.widgets.ExternalBrowser._map[ id ] = win; 
      }
    }

Obviously the if line should be win !== null

Funny enough Safari returns on window.open null but evaluates ( win !== null ) as true. Therefore the script fails on win.focus().

Please see the attached patch to fix this issue.