Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 268474 - [Net] CVS connections fail with the "Native" Proxy provider
Summary: [Net] CVS connections fail with the "Native" Proxy provider
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-13 01:32 EDT by Masashi Sato CLA
Modified: 2009-06-01 09:55 EDT (History)
2 users (show)

See Also:


Attachments
proxy setting screen shots (50.87 KB, application/octet-stream)
2009-03-13 01:32 EDT, Masashi Sato CLA
no flags Details
Patch_v01 (1.51 KB, patch)
2009-03-13 07:25 EDT, Pawel Pogorzelski CLA
john.arthorne: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Masashi Sato CLA 2009-03-13 01:32:21 EDT
Created attachment 128652 [details]
proxy setting screen shots

Build ID:  I20090202-1535

Steps To Reproduce:
1. In Internet Explorer Proxy Setting page, check "Use the same proxy server for all protocols" and specify proxy server to HTTP field.
2. In Eclipse Network Connections page, select "Native" as Active Provider.
3. Add a new cvs repository with pserver.


I found some the relating incidents. 
But I think that the problem is in the following for my case. 

I don't have a socks proxy. 
However, when the above-mentioned setting is specified, the SOCK proxy server is specified in Eclipse Network Connections page, and SOCKS proxy is used by priority, and HTTPS proxy is not used for cvs. 

In Internet Explorer proxy setting, the socks proxy field is cleared, when the option "Use the same proxy server for all protocols" is specified, 

Nevertheless, I think that it is a problem that the following definitions are in the following source, and the proxy server value is used even for SOCKS. 

org.eclipse.core.net/src/org/eclipse/core/internal/net/proxy/win32/winhttp/StaticProxyConfig.java
	private static final String[] KNOWN_TYPES = {"HTTP", "HTTPS", "FTP", "GOPHER", "SOCKS"};
Comment 1 Pawel Pogorzelski CLA 2009-03-13 06:50:04 EDT
(In reply to comment #0)
> <proxy deleted/>
> In Internet Explorer proxy setting, the socks proxy field is cleared, when the
> option "Use the same proxy server for all protocols" is specified, 

Right, we should clear it in Eclipse as well.

> Nevertheless, I think that it is a problem that the following definitions are
> in the following source, and the proxy server value is used even for SOCKS. 

Why is that a problem?
Comment 2 Pawel Pogorzelski CLA 2009-03-13 07:25:43 EDT
Created attachment 128686 [details]
Patch_v01

Masashi, fix exactly in the place you suggested. Thanks for your help.
Comment 3 Szymon Brandys CLA 2009-03-17 05:35:43 EDT
Patch_v01 released to HEAD.
Comment 4 John Arthorne CLA 2009-06-01 09:55:57 EDT
Removing iplog+ from bug - this indicates an IP contribution in a comment
rather than a patch.

http://wiki.eclipse.org/Development_Resources/Automatic_IP_Log