Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 268430 - test new ant task to generate packed files in repo
Summary: test new ant task to generate packed files in repo
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-12 16:10 EDT by Kim Moir CLA
Modified: 2009-03-27 11:52 EDT (History)
1 user (show)

See Also:


Attachments
patch (6.80 KB, patch)
2009-03-17 11:21 EDT, Kim Moir CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Moir CLA 2009-03-12 16:10:17 EDT
<p2.process.artifacts repositoryPath="${p2.build.repo}"	 pack="true"	/>

Also, these tasks should be cleaned up in buildAll.xml
<antcall target="packMasterFeature" />
<antcall target="unpackUpdateJarsForPackaging" />
<antcall target="buildUpdateSite" />
Comment 1 Kim Moir CLA 2009-03-12 16:32:37 EDT
Also, the source build needs to be completely refactored to use p2 to provision the bundles instead of using the assemble scripts that are included in the build.
Comment 2 Kim Moir CLA 2009-03-12 16:33:42 EDT
whoops, comment #2 was for another bug
Comment 3 Kim Moir CLA 2009-03-17 11:21:46 EDT
Created attachment 129095 [details]
patch
Comment 4 Nick Boldt CLA 2009-03-18 21:25:02 EDT
(In reply to comment #0)
> <p2.process.artifacts repositoryPath="${p2.build.repo}"  pack="true"    />
> 
> Also, these tasks should be cleaned up in buildAll.xml
> <antcall target="packMasterFeature" />
> <antcall target="unpackUpdateJarsForPackaging" />
> <antcall target="buildUpdateSite" />

You might like this replacement for buildUpdateSite:

http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.dash/athena/org.eclipse.dash.commonbuilder/org.eclipse.dash.commonbuilder.releng/tools/scripts/buildAllHelper.xml?root=Technology_Project&view=markup

(see buildUpdate task, )

Two limitations of this solution are:

bug 269226 - generate site.xml because p2 won't show uncategorized features
bug 269199 - don't use packed jars because p2 can't handle them 
bug 252035 - Provide a p2 repo after the master feature is built
Comment 5 Kim Moir CLA 2009-03-27 11:52:54 EDT
Closing this bug.  The packed files are now in the repo.  I didn't change these tasks around

<antcall target="packMasterFeature" />
<antcall target="unpackUpdateJarsForPackaging" />
<antcall target="buildUpdateSite" />

Some of these zips are still used for the packager.  

Nick, thanks for the link but I think we'll stick to using the p2 tasks to create the update site repo.

<p2.metadata.mirror source="${p2.build.repo}" writeMode="append" destination="file:${buildRepo}" />
<p2.artifact.mirror source="${p2.build.repo}" baseline="file:${updateSite}" comparatorId="org.eclipse.equinox.p2.repository.tools.jar.comparator"  destination="file:${buildRepo}" ignoreErrors="true"/>
				
<copy todir="${buildRepo}">
  <fileset file="${eclipse.build.configs}/../../extras/sdkinstaller.properties" />
</copy>

in org.eclipse.releng.eclipsebuilder\equinox\buildConfigs\equinox.prov\run.xml
<!--generate packed jars in repo-->
<p2.process.artifacts repositoryPath="file://${buildRepo}"  pack="true"    />
<!--update metadata with information on packed jars -->
<antcall target="update.pack200" />