Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 267963 - Bug in ProfileScope
Summary: Bug in ProfileScope
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-10 15:54 EDT by DJ Houghton CLA
Modified: 2009-03-10 17:40 EDT (History)
1 user (show)

See Also:

Attachments
ProfileScope (1.50 KB, patch)
2009-03-10 17:22 EDT, Matthew Piggott CLA 		dj.houghton: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2009-03-10 15:54:33 EDT 
I was just looking at the code for ProfileScope and it inherits #getNode from AbstractScope but this is incorrect. It will return /profile/com.example rather than /profile/myProfileId/com.example.

(see ProjectScope... it over-rides the method to add the extra level)
Comment 1 Matthew Piggott CLA 2009-03-10 17:22:50 EDT 
Created attachment 128281 [details]
ProfileScope

Added the getNode() method, I wonder if it would make more sense if it were to simply implement IScopeContext rather than extend AbstractScope, at the moment it does not appear that it is inheriting anything useful.
Comment 2 John Arthorne CLA 2009-03-10 17:32:16 EDT 
What is the implication of this bug on current behaviour?
Comment 3 DJ Houghton CLA 2009-03-10 17:34:12 EDT 
Good idea. I've made this change and released the new method.
Comment 4 DJ Houghton CLA 2009-03-10 17:40:52 EDT 
I don't believe that anyone is using the scope class to get the pref nodes but if they were, then they would be pointing to the wrong location.