Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 267682 - [navigation] 'Open Implementation' on super method invocation should not open quick type hierarchy
Summary: [navigation] 'Open Implementation' on super method invocation should not open...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Raksha Vasisht CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-09 13:23 EDT by Markus Keller CLA
Modified: 2009-03-16 10:52 EDT (History)
1 user (show)

See Also:


Attachments
Patch with the fix. (1.44 KB, patch)
2009-03-13 06:32 EDT, Raksha Vasisht CLA
daniel_megert: iplog+
daniel_megert: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-03-09 13:23:43 EDT
After bug 266443.

'Open Implementation' on a super method invocation should not open the quick type hierarchy.

Example:

package p;

class A {
        public void method() {}
}

class B extends A {
        public void method() {}

        void xx() {
                super.method();
                super.hashCode();
        }
}


Open Implementation of "method" in "super.method()" should just open the declaration of A#method(). SuperMethodInvocations are a special case, because the call is never polymorphic.
Similar case for "super.hashCode();": Should open Object#hashCode().
Comment 1 Raksha Vasisht CLA 2009-03-13 06:32:23 EDT
Created attachment 128679 [details]
Patch with the fix.
Comment 2 Dani Megert CLA 2009-03-16 10:52:53 EDT
Thanks for the patch Raksha!

Fixed in HEAD.
Available in builds > N20090315-2000.