Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 267456 - Need to update the service registry impl to use the new ServicePermisson changes
Summary: Need to update the service registry impl to use the new ServicePermisson changes
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: BJ Hargrave CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-06 17:27 EST by Thomas Watson CLA
Modified: 2009-04-02 09:39 EDT (History)
1 user (show)

See Also:

Attachments
Patch for ServiceRegistry impl compliant to RFC131 (7.88 KB, patch)
2009-03-07 06:11 EST, Ikuo Yamasaki CLA 		tjwatson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2009-03-06 17:27:09 EST 
RFC 131 changed how ServicePermissions should be checked.  The service registry implementation needs to be updated to use the changes to ServicePermission.
Comment 1 Ikuo Yamasaki CLA 2009-03-07 06:11:17 EST 
Created attachment 127903 [details]
Patch for ServiceRegistry impl compliant to RFC131

I had written ServiceRegistry.java compliant to RFC131.

In addition, I had commited CT for RFC131. RI(Equinox impl applied with the patch) passes the CT.

https://www.osgi.org/members/svn/build/trunk/org.osgi.test.cases.permissions.filtered/
Comment 2 Thomas Watson CLA 2009-03-08 10:59:15 EDT 
I released the latest org.osgi.framework permission classes to equinox.  Still need BJ to review Ikou's patch or provide an alternative for M6.
Comment 3 BJ Hargrave CLA 2009-04-01 21:41:15 EDT 
I committed changes to use the new ServicePermission constructor for GET permissions checks. I tested the change successfully against the new OSGi compliance tests from Ikuo.

I did not use Ikuo's patch directly. I used it as a reference to confirm I did not miss any of the areas Ikuo changed in the patch.
Comment 4 Thomas Watson CLA 2009-04-02 09:39:20 EDT 
Comment on attachment 127903 [details]
Patch for ServiceRegistry impl compliant to RFC131

We should add Ikou to the iplog since you used his patch as guidance in the final fix.