Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 267277 - AbstractApplication removing repositories incorrectly
Summary: AbstractApplication removing repositories incorrectly
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-05 17:40 EST by Matthew Piggott CLA
Modified: 2009-04-13 15:34 EDT (History)
2 users (show)

See Also:

Attachments
AbstractApplication patch (1.71 KB, patch)
2009-03-05 17:40 EST, Matthew Piggott CLA 		john.arthorne: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Piggott CLA 2009-03-05 17:40:43 EST 
Created attachment 127724 [details]
AbstractApplication patch

In the initializeDestination methods of AbstractApplication there is a check to determine if the RepositoryManager contains the location, and if so it is added to the repositories to remove at the end of execution.

Perhaps I'm missing something, but I believe the intent is to ensure that if the task introduces a new repository to the manager it should be removed later.  In which case we should reverse the check to add the location to be removed if the location is unknown as is the case in the initializeRepos method.
Comment 1 John Arthorne CLA 2009-04-13 15:33:47 EDT 
Fix released.