Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 267264 - [target] Add group by location to EditProfileContainerWizard
Summary: [target] Add group by location to EditProfileContainerWizard
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Ankur Sharma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-05 15:43 EST by Curtis Windatt CLA
Modified: 2009-03-30 17:17 EDT (History)
1 user (show)

See Also:


Attachments
Patch with group by location (35.36 KB, patch)
2009-03-10 16:03 EDT, Ankur Sharma CLA
curtis.windatt.public: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2009-03-05 15:43:22 EST
People have been asking for the ability to see the bundles in their target grouped by location.  This was possible before the new target story.  While we already separate this in a more transparent manner for directories and features, installations can come from multiple locations.  Users with installations that point to multiple extension locations want to be able to include/exclude different locations.

In M7 we may have to rethink the UI to support this scenario better (alogn with other enhancements like adding required bundles).  However, for M6 we should offer a group by location option when editing a Profile/Installation container.
Comment 1 Curtis Windatt CLA 2009-03-05 15:46:30 EST
Ankur, the tree that is displayed in the Edit wizard is shared by the different container edit wizards.  The class is IncludedBundlesTree.java.

It is probably best to have a "Group by location" checkbox, perhaps under the table.  The old preference page did this so you may be able to use that code to guide you.
Comment 2 Ankur Sharma CLA 2009-03-09 17:20:03 EDT
Stuck with an issue here. When some filter text is entered the checked status of tree items is lost. Problem is that the CheckboxTreeViewer doesn't gives me any listener to catch that. You can see that happening in current page as well.

Any tips/hints?
Comment 3 Ankur Sharma CLA 2009-03-10 16:03:35 EDT
Created attachment 128263 [details]
Patch with group by location

The Group by location is working. However, the selections are messed up if filter is applied. I am working on it. Planning to hook to SWT.PaintItem for the Tree directly. Let me know, if you feel there is an easier/cleaner way to do it.
Comment 4 Curtis Windatt CLA 2009-03-12 11:13:54 EDT
Only critical fixes are being allowed into M6 this week, so this one will have to be pushed to M7.

Ankur, since we are going to be discussing some further UI changes in M7, this bug may become obsolete.  So for now move on to something else.
Comment 5 Ankur Sharma CLA 2009-03-29 13:59:54 EDT
Have we finalized the target ui yet? let me know if there is any change in plan/requirement for this one.
Comment 6 Curtis Windatt CLA 2009-03-30 10:06:29 EDT
There is still one pending major UI change that would affect how this would work.  Ping me and we can discuss it.
Comment 7 Curtis Windatt CLA 2009-03-30 17:17:45 EDT
Applied the patch.  Even though we are going to make some UI changes.  We are still going to want similar group by functionality.  Might as well use your work rather than start from scratch.