Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 266737 - [target] "Save As" does not work on the Target Definition Editor
Summary: [target] "Save As" does not work on the Target Definition Editor
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Ankur Sharma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-02 14:51 EST by Ankur Sharma CLA
Modified: 2009-03-30 16:47 EDT (History)
1 user (show)

See Also:

Attachments
Patch (4.19 KB, patch)
2009-03-30 14:23 EDT, Ankur Sharma CLA 		no flags Details | Diff
Updated Patch (4.77 KB, patch)
2009-03-30 16:33 EDT, Ankur Sharma CLA 		curtis.windatt.public: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ankur Sharma CLA 2009-03-02 14:51:01 EST 
Build ID: I20090224-0800

Steps To Reproduce:
1. Create a new target definition using File -> New -> Target Definition
2. Save is as a file in the workspace.
3. Open it. It will open in the Target Definition Editor
4. Do File -> Save As. Nothing happens

Either the Save As should be made functional or it should be disabled.


More information:
Comment 1 Curtis Windatt CLA 2009-03-02 15:06:41 EST 
I was waiting to see how long it would take before someone noticed and filed a bug :)

If anybody wants to finish it up, go for it.
Comment 2 Curtis Windatt CLA 2009-03-16 14:15:52 EDT 
If you run out of other things Ankur this is something we realistically need done for 3.5.
Comment 3 Ankur Sharma CLA 2009-03-30 14:23:04 EDT 
Created attachment 130283 [details]
Patch
Comment 4 Curtis Windatt CLA 2009-03-30 15:10:09 EDT 
The saving of the model to the new file works correctly, however, the old editor stays open and is marked as dirty.  We should be reloading the editor with the correct file input.
Comment 5 Ankur Sharma CLA 2009-03-30 15:53:04 EDT 
completely missed that. Thanks for catching it Curtis. I have been wondering all the while why the fix is so simple, i must be missing something :(
Comment 6 Ankur Sharma CLA 2009-03-30 16:33:34 EDT 
Created attachment 130305 [details]
Updated Patch

Added code to refresh the editor with the new target. new Editor Input and listeners registered. Pages committed to clear dirty state. and editorDirtyStateChanged to trigger the notify.

Do let me know if I overlooked something.
Comment 7 Curtis Windatt CLA 2009-03-30 16:46:53 EDT 
Much better, applied the patch.