Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 266492 - FileUtility#getPathNodes is inefficient for large change sets
Summary: FileUtility#getPathNodes is inefficient for large change sets
Status: RESOLVED FIXED
Alias: None
Product: Subversive
Classification: Technology
Component: Core (show other bugs)
Version: 0.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Igor Burilo CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 287559
  Show dependency tree
 
Reported: 2009-02-27 09:45 EST by Igor Fedorenko CLA
Modified: 2011-05-18 06:48 EDT (History)
2 users (show)

See Also:

Attachments
Proposed fix (638 bytes, patch)
2009-02-27 09:45 EST, Igor Fedorenko CLA 		i.vinnykov: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Fedorenko CLA 2009-02-27 09:45:24 EST 
Created attachment 126997 [details]
Proposed fix

org.eclipse.team.svn.core.utility.FileUtility#getPathNodes(IResource[]) uses ArrayList#contains which is inefficient on large data sets. I am attaching possible fix which seems to improve performance of certain operations. Keep in mind that I am not familiar with Subversive codebase, and there may be better ways to solve the problem.

Please note that this is different from problem described in #259287.
Comment 1 Jörg Thönnes CLA 2009-02-27 09:53:17 EST 
Thanks, Igor. Looking forward to see this in the code base.
Comment 2 Igor Burilo CLA 2010-03-10 05:32:12 EST 
Applied patch.