Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 266442 - [navigation] JavaElementImplementationHyperlink.open() must show dialog in case of error
Summary: [navigation] JavaElementImplementationHyperlink.open() must show dialog in ca...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Raksha Vasisht CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-27 04:10 EST by Dani Megert CLA
Modified: 2009-03-06 06:40 EST (History)
1 user (show)

See Also:

Attachments
Patch with JavaElementImplementationHyperlink.open() showing error dialog and message. (4.73 KB, patch)
2009-03-05 04:55 EST, Raksha Vasisht CLA 		markus.kell.r: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2009-02-27 04:10:33 EST 
HEAD.

In case of error JavaElementImplementationHyperlink.open() currently logs the error with "" as message. This is not good:
- it must use an appropriate message
- it must show an ErrorDialog to the user
Comment 1 Raksha Vasisht CLA 2009-03-05 04:55:34 EST 
Created attachment 127631 [details]
Patch with JavaElementImplementationHyperlink.open() showing error dialog and message.
Comment 2 Markus Keller CLA 2009-03-06 06:40:32 EST 
- Why is there a space after "catch (InvocationTargetException e"?
- The title of the error dialog should be the name of the user action.
- The InvocationTargetException is not too interesting. We should log the actual exception inside it.
- typo in ...found_message: *I*mplementations

Released to HEAD with a few fixes. Please have a look at my changes.