Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 266388 - Make ProfileLock not re-entrant
Summary: Make ProfileLock not re-entrant
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-26 17:13 EST by Simon Kaegi CLA
Modified: 2009-03-06 11:32 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2009-02-26 17:13:36 EST 
Currently the profile lock is re-entrant. Pretty cool right...

I'm beginning to think it really isn't so cool like when John begins to show me things like bug 266205. There are some nasty cases where the inner transaction could update the profile and later on the outer transaction would merrily overwrite those changes. I think the profile lock should probably be a regular old style non-reentrant fail-fast mutex until we know what we're getting into.
Comment 1 John Arthorne CLA 2009-03-03 16:50:34 EST 
As we learned in bug 266881, re-entrant engine calls can cause all sorts of bad things to happen, as we are often making the assumption that there is only one active engine session. We should make this change soon to protect against more failures like that one.
Comment 2 Simon Kaegi CLA 2009-03-06 11:32:03 EST 
Fixed in HEAD