This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 266250 - Reimport the Eclipse 3.2 translations for TPTP [was: Map file processor not running properly on live server]
Summary: Reimport the Eclipse 3.2 translations for TPTP [was: Map file processor not r...
Status: RESOLVED WONTFIX
Alias: None
Product: Babel
Classification: Technology
Component: Server (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Denis Roy CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-25 23:09 EST by Kit Lo CLA
Modified: 2011-06-09 11:48 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2009-02-25 23:09:46 EST
I know that there are at least 2 recent new entries to the map file table:
- rt.equinox 3.4.1
- tptp.platform 4.5.3

However, I waited a few days but still do not see the projects and their files showing up on the translate page.
Comment 1 Antoine Toulmé CLA 2009-02-26 04:14:31 EST
Of course, that's because of 265301, and that's why I asked for a release on the call last Monday.
Comment 2 Antoine Toulmé CLA 2009-03-01 06:28:20 EST
There was one glitch remaining. I fixed it.
Comment 3 Antoine Toulmé CLA 2009-03-01 06:39:50 EST
I tagged a new release I improperly named R_0_200901031229 (sorry) with a fix in process_map_files.php.

I am running the process_map_files script now and no particular errors are thrown.

Comment 4 Antoine Toulmé CLA 2009-03-01 10:49:17 EST
Files are showing up and the completion percentages should be computed by tomorrow hopefully.
Comment 5 Kit Lo CLA 2009-03-02 00:03:31 EST
Some projects seem to be fixed. But, some like STP is still broke on the live server.

Also, many (if not all) projects like birt, eclipse, stp, webtools still do not show any files on the staging server. The staging server should have the same fix, right?
Comment 6 Antoine Toulmé CLA 2009-03-02 05:21:37 EST
Yes, stp and stp.bpmn seem to be missing.

For the staging area, I simply didn't run process_map_files.php entirely.

If you'd like to run it, just enter this URL in your process:

http://babel.eclipse.org/staging/(_REMOVE_THIS_)process_map_files.php.
Comment 7 Joel Cayne CLA 2009-03-02 08:52:25 EST
TPTP is still not showing up in the download files or translate page (http://babel.eclipse.org/babel/translate.php). Is there an error in the way I entered the map files? Do the entries for different release versions (i.e. GA, SR1, SR2) under one release train cause them not to show up?
Comment 8 Antoine Toulmé CLA 2009-03-02 08:58:37 EST
Which TPTP are you referring to ? I see 4 different projects under that TLP.
tptp.performance, tptp.test, etc.

I also can't see any version named SR1, SR2 or GA. Please look at this page and fill up what's missing:
http://babel.eclipse.org/babel/map_files.php

If you have a doubt on one of your map files, please paste its address here.
Comment 9 Joel Cayne CLA 2009-03-02 09:16:20 EST
(In reply to comment #8)
> Which TPTP are you referring to ? I see 4 different projects under that TLP.
> tptp.performance, tptp.test, etc.
> 
tptp.platform

As we do not have a generic TPTP project entry (see http://bugs.eclipse.org/266541) I have updated it under the one sub-project for all of TPTP with our map file http://dev.eclipse.org/viewcvs/index.cgi/platform/org.eclipse.hyades.releng.builder/master/maps/hyades.map?root=TPTP_Project&view=co.

> I also can't see any version named SR1, SR2 or GA. Please look at this page and
> fill up what's missing:
> http://babel.eclipse.org/babel/map_files.php
> 
> If you have a doubt on one of your map files, please paste its address here.
> 

I was matching it to the SR releases so it would make it easier for you to match it to the Ganymede releases. Specifically, I added them to 4.5.1, 4.5.2, and unspecified which correspond to TPTP's SR1, SR2 and Galileo. The unspecified one is now missing so it seems my updates last week were lost. I have updated the links again now. I noticed that our entries were not associated with a train, so I deleted the existing ones for 4.5.1, 4.5.2 and re-added them as well.
Comment 10 Joel Cayne CLA 2009-03-02 09:18:42 EST
Note, I updated http://babel.eclipse.org/staging/map_files.php which had the incorrect entries, is it possible this site has not been updated with the entries from http://babel.eclipse.org/babel/map_files.php?
Comment 11 Antoine Toulmé CLA 2009-03-02 09:31:28 EST
Staging and live are two separate entities, and you should always define stuff in live, while staging is meant for developers to test the code.
Comment 12 Antoine Toulmé CLA 2009-03-02 09:33:18 EST
I am running the process_map_files.php script again, let's see if that changes something for you.
Comment 13 Kit Lo CLA 2009-03-02 14:40:08 EST
The original problem reported may be related to the content of the map files.

Equinox has extra "CVS,tag,cvsRoot" labels:
plugin@org.eclipse.equinox.p2.artifact.repository=CVS,tag=R34x_v20080808-1156,cvsRoot=:pserver:anonymous@dev.eclipse.org:/cvsroot/rt,path=org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.artifact.repository

TPTP does not have the ":pserver:anonymous" info:
plugin@org.eclipse.tptp.monitoring=v200901090956,tptp:/cvsroot/tptp,,monitoring/org.eclipse.tptp.monitoring
Comment 14 Denis Roy CLA 2009-03-02 14:57:11 EST
Kit is right.  If the map file doesn't provide the full CVS connection info, then we're out of luck.

We could perhaps 'catch' this in the maps processor, but in reality, it would be good for the map file to specify CVS host info.  This would allow external entities to build TPTP projects with greater ease.
Comment 15 Joel Cayne CLA 2009-03-02 15:00:47 EST
Can a psf file be used? It contains the same contents as our map file but with the CVS information and is meant for consumers.
Comment 16 Antoine Toulmé CLA 2009-03-02 15:11:49 EST
(In reply to comment #15)
> Can a psf file be used? It contains the same contents as our map file but with
> the CVS information and is meant for consumers.
> 
Can a psf file point at a tag ?

I proposed during today's call that we show the information we could find in the map file in the same interface, and that we let committers edit it. We should also let committers add their own plugin locations, and eventually not have to migrate away from map files.
Comment 17 Joel Cayne CLA 2009-03-02 15:21:26 EST
Yes a psf can point to a tag, e.g. http://www.eclipse.org/tptp/home/documents/resources/projectSets/TPTPProjectSet440.psf. Alternatively, is there a way we can define that tptp:/cvsroot/tptp means :pserver:anonymous@dev.eclipse.org:/cvsroot/tptp?

Where is the interface where committers could see the information of what was found in the map file?
Comment 18 Antoine Toulmé CLA 2009-03-02 16:30:15 EST
(In reply to comment #17)
> 
> Where is the interface where committers could see the information of what was
> found in the map file?
> 

It is not done yet. Do you have spare time and do you feel like messing with some PHP ?
Comment 19 Kit Lo CLA 2009-03-04 12:02:40 EST
Regarding comment #13, I found some info about map file syntax.

http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.pde.doc.user/guide/tasks/pde_fetch_phase.htm

Looks like Equinox's syntax with "cvsRoot", "path" args was valid.
Comment 20 Joel Cayne CLA 2009-03-05 17:37:23 EST
(In reply to comment #18)
> It is not done yet. Do you have spare time and do you feel like messing with
> some PHP ?
> 

I took a quick look at the PHP and I can see how it separates on the cvsroot.
Comment 21 Kit Lo CLA 2009-03-12 14:28:34 EDT
I figured the problem. Logics in the server string class expects a file_id of 0 to mean a non-existing file. However, the file class initialized the file_id to -1. process_map_files.php did not insert any of the new strings from map files into the strings table.

I initialized the return value for file.getFileID() to 0. The process_map_files.php is running properly again. TPTP strings are now extracted and made available for translation on the translate page.

I also added some logics in process_map_files.php to skip the "CVS,tag,cvsRoot,path" keys. Equinox/P2 strings are also extracted properly now.

Patch released to staging server.
Comment 22 Denis Roy CLA 2009-03-16 13:09:08 EDT
> TPTP strings are now extracted

Reopening ... I need to reimport the Eclipse 3.2 translations.
Comment 23 Denis Roy CLA 2011-06-09 11:48:39 EDT
I don't think anything useful will come out of this bug.