Comment 1 Paul Webster 2012-10-16 09:34:48 EDT

*** Bug 392038 has been marked as a duplicate of this bug. ***

Comment 2 Krzysztof Daniel 2012-10-17 06:26:57 EDT

In Fedora we use batik-1.8-0.4.svn1230816 and it seems to work fine - no error reports.

Comment 3 Daniel Rolka 2013-09-10 09:35:08 EDT

Created attachment 235352 [details]
Benchmark test launcher

Short instruction for application:
- unzip the archive file
- import projects to the workspace and build sources (at this moment the PDE build is supported only)
- using the 'org.eclipse.e4.ui.css.benchmark/org.eclipse.e4.ui.css.benchmark.product' configuration launch the RCP application
- Select parsers/test suites/tests that you would like to execute and press the 'Execute test suites' button
- When test results are ready, press the 'Show results' button to display the report. The report can be save to the file with the 'Save results to file' button

Daniel

Comment 4 Daniel Rolka 2013-09-10 09:45:15 EDT

Created attachment 235353 [details]
The SAC parsers benchmark tests report

Paul, Bogdan,

I have made couple benchmark tests of the SAC parser using the launcher application(see attachments). I was using the following parsers in my tests:
 * org.w3c.flute.parser.Parser, 1.3.0,
 * org.apache.batik.css.parser.Parser, 1.6.0
 * org.apache.batik.css.parser.Parser, 1.7.0
 * com.steadystate.css.parser.SACParserCSS2, 0.9.5 (Unfortunately this version did not work and I've not checked other versions of this parser)

According to the test report the best results gives the parser org.apache.batik.css.parser.Parser 1.7.0 (see the report). The report has been created using the Windows 7 OS. However using the application it can be generated for the rest supported systems.

Basically we are quite loose coupled with parser since we use it via the SAC W3C API (bundle org.w3c.css.sac, 1.3.0). The rest of processing is done by the code in the org.eclipse.e4.ui.css.core bundle. 

Please let me know if you are going to check other parsers(I've not found anything interesting), perform other tests or we are going to use the Batik 1.7.0

If you have any other comments just let me know,
Daniel

Comment 5 Paul Webster 2013-09-13 14:54:59 EDT

(In reply to Daniel Rolka from comment #4)
> Please let me know if you are going to check other parsers(I've not found
> anything interesting), perform other tests or we are going to use the Batik
> 1.7.0

Thanks you for your report and your analysis.  It looks like we should go ahead and use Batik 1.7.0

PW

Comment 6 Daniel Rolka 2013-09-24 02:37:15 EDT

Gerrit review link: https://git.eclipse.org/r/#/c/16687/

Daniel

Comment 7 Paul Webster 2013-09-26 16:41:51 EDT

I've released your change as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=287abef5328cdd358799a17c8caa2fdfe4e90f19

Thanks Daniel.

We need to check tonight's nightly build to make sure it worked and the SDK contains the correct bundles.

PW

Comment 8 Daniel Rolka 2013-09-27 04:04:06 EDT

Verified in the build: N20130926-2000

Paul,

I've checked the build and it looks good. All required Batik bundles are properly updated, the workbench, the RCP 3.x as well as the RCP 4.x applications work fine.
However I will monitor the Bugzilla in the case of any regression related to this change.

Daniel

Comment 9 Daniel Rolka 2013-10-29 09:02:45 EDT

Verified in the build: I20131028-2000

Comment 10 Paul Webster 2014-05-14 10:11:21 EDT

The CQ to use this: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=8287

PW

Comment 11 Daniel Rolka 2014-09-19 06:30:50 EDT

Created attachment 247235 [details]
Benchmark test launcher adjusted for Mars