Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 266146 - [CSS] JUnit for: Property retrieval must check instanceof and return null
Summary: [CSS] JUnit for: Property retrieval must check instanceof and return null
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.1   Edit
Assignee: Aghiles Abdesselam CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 266028
Blocks:
  Show dependency tree
 
Reported: 2009-02-25 10:39 EST by Aghiles Abdesselam CLA
Modified: 2011-05-17 16:23 EDT (History)
1 user (show)

See Also:

Attachments
junit test (1.99 KB, patch)
2009-02-25 10:39 EST, Aghiles Abdesselam CLA 		no flags Details | Diff
junit test for retrieveCSSProperty() (2.76 KB, patch)
2009-02-26 09:29 EST, Aghiles Abdesselam CLA 		john.arthorne: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aghiles Abdesselam CLA 2009-02-25 10:39:07 EST 
Created attachment 126734 [details]
junit test
Comment 1 Kevin McGuire CLA 2009-02-25 20:43:36 EST 
The patch looks ok but two points:

1) The tests should probably be in CTabFolderTest.java because the tests are specifically testing that the CTabFolder property handlers return null when not given an CTabFolder.  

The test class name is misleading anyway, since it's called RetrievePropertyTest, but we already have property retrieval tests in CTabFolderTest.

Do you agree?  If so then please move the tests and resubmit.

2) Just a reminder that when adding a new test class, you need to remember to also add that class to CssSwtTestSuite.  Otherwise it won't get run when the test suite is run.
Comment 2 Aghiles Abdesselam CLA 2009-02-26 09:29:27 EST 
Created attachment 126844 [details]
junit test for retrieveCSSProperty()
Comment 3 Kevin McGuire CLA 2009-03-03 22:54:27 EST 
Released