Community
Participate
Working Groups
I20090224-0800. Example can be found e.g. in refactoringui.properties: PullUpInputPage1_status_line={0} member(s) selected.
There are too many of these to fix so late in the cycle.
Created attachment 150440 [details] Patch 29 strings updated in all.
Reviewed LTK changes. Patch is good but changed some minor details: - moved the strings from ScriptingMessages to RefactoringUIMessages as it makes no sense that they are separated - replaced "1" with "the" ==> Are you sure you want to delete the refactoring...
Reviewed JDT UI changes: Patch is good but I modified the patch a little bit - I generally prefer to not write the same code twice i.e. instead of if (...) set(x); else set(y); I prefer: String m= ... ? X : Y. set(m); or sometimes even: set(... ? X : Y); Typo: ReorgPolicyFactory_copy_roots_header_singular=Copy source folders to ''{1}'' ==> ReorgPolicyFactory_copy_roots_header_singular=Copy source folder to ''{1}'' In case where there's just one element/thing, we often use the name/label, e.g. "Move method 'foo()' to X" instead of "Move method to X". Please revisit your patch (HEAD now) and check whether there are places where this applies. There are still 15 remaining cases in JDT UI and please also fix it for org.eclipse.jdt.junit.
Created attachment 151917 [details] fix for remaining strings (In reply to comment #4) > There are still 15 remaining cases in JDT UI and please also fix it for > org.eclipse.jdt.junit. Done, 45 strings fixed in total. (44 in JDT UI and 1 in org.eclipse.jdt.junit) Will delete 2 keys (ShowInNavigator_description, SelectionTransferDropAdapter_dialog_question) as part of 294552. For the following string keys there is no count hence I have used the plural form here -OpenProjectAction_dialog_message -NewVariableEntryDialog_info_noselection -JarFileExportOperation_classFileOnClasspathNotAccessible -ExtractMethodRefactoring_add_method -ExtractMethodRefactoring_substitute_with_call -JUnitPreferencePage_addpackagebutton_tooltip For 'PromoteTempInputPage_constructors' there is a count but it was hard to determine hence I have left it as is For the rest I have created 2 strings (singular and plural forms) > In case where there's just one element/thing, we often use the name/label, e.g. > "Move method 'foo()' to X" instead of "Move method to X". Please revisit your > patch (HEAD now) and check whether there are places where this applies. Will create another patch for this.
For the JUnit changes: the correct fix is to remove the tool tips from the buttons (text buttons must not have tool tips). Fixed that in HEAD.
Committed to HEAD with the following changes: - made the logic in the following classes more readable (please verify) - AddDelegateMethodsAction - AddGetterSetterAction - {0} Duplicate methods selected ==> {0} duplicate methods selected >For 'PromoteTempInputPage_constructors' there is a count but it was hard to >determine hence I have left it as is Replaced "(s)" with "s". Available in builds > N20091111-2000. Please file a new bug for the remaining issue: > In case where there's just one element/thing, we often use the name/label, e.g. > "Move method 'foo()' to X" instead of "Move method to X". Please revisit your > patch (HEAD now) and check whether there are places where this applies.
(In reply to comment #7) > - made the logic in the following classes more readable (please verify) > - AddDelegateMethodsAction > - AddGetterSetterAction Verified. > Please file a new bug for the remaining issue: > > In case where there's just one element/thing, we often use the name/label, e.g. > > "Move method 'foo()' to X" instead of "Move method to X". Please revisit your > > patch (HEAD now) and check whether there are places where this applies. Filed Bug 294970 for this.
Verified for 3.6 M4 with I20091207-1800.
