Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 266028 - [CSS] Property retrieval must check instanceof and return null
Summary: [CSS] Property retrieval must check instanceof and return null
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.1   Edit
Assignee: Aghiles Abdesselam CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 266146
  Show dependency tree
 
Reported: 2009-02-24 16:15 EST by Aghiles Abdesselam CLA
Modified: 2011-05-17 16:23 EDT (History)
1 user (show)

See Also:

Attachments
instanceof check and will return null when appropriate (11.80 KB, patch)
2009-02-24 16:36 EST, Aghiles Abdesselam CLA 		john.arthorne: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aghiles Abdesselam CLA 2009-02-24 16:15:49 EST 
Due to bug #266027 , we should be checking to ensure the widget is of the right class with an instanceof check and if not matching return null.
Comment 1 Aghiles Abdesselam CLA 2009-02-24 16:36:39 EST 
Created attachment 126618 [details]
instanceof check and will return null when appropriate
Comment 2 Kevin McGuire CLA 2009-02-24 17:36:55 EST 
Committed changes.

Ideally the junits would've caught this bug.  Can you add a test? (open as separate bug dependent on this one).