Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 265931 - Autostart values are not persisted correctly in the product file
Summary: Autostart values are not persisted correctly in the product file
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-24 04:34 EST by Wassim Melhem CLA
Modified: 2009-02-24 11:05 EST (History)
2 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2009-02-24 07:04 EST, Benjamin Cabé CLA 		no flags Details | Diff
mylyn/context/zip (1.29 KB, application/octet-stream)
2009-02-24 07:04 EST, Benjamin Cabé CLA 		no flags Details
Updated patch (6.88 KB, patch)
2009-02-24 07:44 EST, Benjamin Cabé CLA 		caniszczyk: iplog+
Details | Diff
mylyn/context/zip (3.76 KB, application/octet-stream)
2009-02-24 07:44 EST, Benjamin Cabé CLA 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2009-02-24 04:34:19 EST 
3.3 M5

On the Configuration page of the product editor, add a plug-in and set autostart to 'true'.

Save the file.

Open the file in a text editor, and see how the value of the 'autostart' attribute is still set to false.
Comment 1 Benjamin Cabé CLA 2009-02-24 07:04:09 EST 
Created attachment 126538 [details]
Patch

Fuck Sun and their stupid Boolean#getBoolean() method ;)

BTW, Wassim, I've noticed you're reporting a lot of issue against... 3.3M5 !! ;-)
Comment 2 Benjamin Cabé CLA 2009-02-24 07:04:16 EST 
Created attachment 126539 [details]
mylyn/context/zip
Comment 3 Wassim Melhem CLA 2009-02-24 07:27:26 EST 
Good catch, you're right.  I should stop living in the past.

I recently upgraded from 3.3 to 3.5 M5, so I have 3.3 on my mind still.

All these bugs are 3.5 M5 :)
Comment 4 Benjamin Cabé CLA 2009-02-24 07:44:14 EST 
Created attachment 126542 [details]
Updated patch

Some other very bad typos fixed (they caused a bad parsing of product configuration, thus an empty "Configuration" tab content.....)
Comment 5 Benjamin Cabé CLA 2009-02-24 07:44:19 EST 
Created attachment 126543 [details]
mylyn/context/zip
Comment 6 Chris Aniszczyk CLA 2009-02-24 11:03:19 EST 
We have to use something like Boolean.valueOf(element.getAttribute(P_AUTO_START)).booleanValue();

Since parseBoolean I believe exists in Java 5 or 6 and we're targetting 1.4 :o
Comment 7 Chris Aniszczyk CLA 2009-02-24 11:05:34 EST 
Comment on attachment 126542 [details]
Updated patch

Thanks Benjamin!