Description Andrew Niefer 2009-02-20 10:27:36 EST

The test org.eclipse.pde.build/P2Tests#testBug265526_265524 attached to bug 265524 is failing intermittently.  The failure is caused by:
java.io.IOException: Failed to create directory C:\Dev\Platform\Workspaces\junit-workspace\pde.build\265526\outRepo2\plugins\b_1.0.0.
	at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.getOutputStream(SimpleArtifactRepository.java:716)
	at org.eclipse.equinox.internal.p2.artifact.repository.MirrorRequest.transferSingle(MirrorRequest.java:161)
	at org.eclipse.equinox.internal.p2.artifact.repository.MirrorRequest.transfer(MirrorRequest.java:153)
	at org.eclipse.equinox.internal.p2.artifact.repository.MirrorRequest.perform(MirrorRequest.java:94)
	at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.getArtifact(SimpleArtifactRepository.java:502)
	at org.eclipse.equinox.internal.p2.artifact.repository.simple.DownloadJob.run(DownloadJob.java:64)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)


This corresponds to outputFile.mkdirs() failing in SimpleArtifactRepository#getOutputStream.  There is no obvious reason why this should fail.

I suspect a race between download jobs.

My class library has the following for File#mkdirs:
    public boolean mkdirs() {
1	if (exists()) {
	    return false;
	}
2	if (mkdir()) {
 	    return true;
 	}
        File canonFile = null;
        try {
            canonFile = getCanonicalFile();
        } catch (IOException e) {
            return false;
        }
	String parent = canonFile.getParent();
3       return (parent != null) && (new File(parent).mkdirs() &&
                                    canonFile.mkdir());
    }


Consider the following
JobA(repo/plugins/b_1.0.0) 
JobB(repo/plugins/a_1.0.0.jar)
repo/plugins does not previously exist.

JobA 1 (plugins/b_1.0.0)     exists() == false
JobA 2 (plugins/b_1.0.0)     mkdir() == false (plugins does not exist)

JobB 1 (plugins/a_1.0.0.jar) exists() == false
JobB 2 (plugins/a_1.0.0.jar) mkdir() == false (plugins does not exist)
JobB 3 (plugins/a_1.0.0.jar) new File(parent).mkdirs() (recurse to parent)
JobB 1 (plugins)             exists() == false
JobB 2 (plugins)             mkdir() == true

JobA 3 (plugins/b_1.0.0)     new File(parent).mkdirs() (recurse to parent)
JobA 1 (plugins)             exists() == true, return false
JobA 3 (plugins/b_1.0.0)     new File(parent).mkdirs() == false, never try
                             canonFile.mkdir()

The failure seems to go away when I previously create the plugins folder.