265645 – Configure Working Sets Dialog: sort checkbox does not use dialog font

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 265645 - Configure Working Sets Dialog: sort checkbox does not use dialog font

Summary: Configure Working Sets Dialog: sort checkbox does not use dialog font

Status:	RESOLVED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.5
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	3.5 M6
Assignee:	Raksha Vasisht
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2009-02-20 09:32 EST by Dani Megert
Modified:	2009-02-25 05:34 EST (History)
CC List:	0 users

See Also:

Attachments
Set the font. (1.04 KB, patch) 2009-02-24 03:17 EST, Raksha Vasisht	daniel_megert: review-	Details \| Diff
Set the font in createDialogArea(composite). (3.18 KB, patch) 2009-02-24 07:18 EST, Raksha Vasisht	daniel_megert: review-	Details \| Diff
Had left out calls to setFont in createDialogArea(). Removed them now. (3.92 KB, patch) 2009-02-25 00:11 EST, Raksha Vasisht	daniel_megert: review-	Details \| Diff
Added ConfigureWorkingSetAssignementAction dialog changes as well. (7.38 KB, patch) 2009-02-25 05:07 EST, Raksha Vasisht	daniel_megert: iplog+ daniel_megert: review+	Details \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dani Megert

2009-02-20 09:32:11 EST

I20090217-2200.

The 'Configure Working Sets' dialog's sort check box does not use dialog font.

Comment 1 Raksha Vasisht

2009-02-24 03:17:52 EST

Created attachment 126522 [details]
Set the font.

Comment 2 Dani Megert

2009-02-24 03:30:55 EST

Raksha, your fix does fix the problem but I'd like to better (more generically) fix the font issue: there is no need to have all the setFont calls if we use org.eclipse.jface.dialogs.Dialog.applyDialogFont(Control) as last call in createDialogArea(...).

Comment 3 Raksha Vasisht

2009-02-24 07:18:20 EST

Created attachment 126541 [details]
Set the font in createDialogArea(composite).

Comment 4 Dani Megert

2009-02-24 08:06:29 EST

Comment on attachment 126541 [details]
Set the font in createDialogArea(composite).

Raksha, you should remove all calls to setFont.

Comment 5 Raksha Vasisht

2009-02-25 00:11:04 EST

Created attachment 126672 [details]
Had left out calls to setFont in createDialogArea(). Removed them now.

Comment 6 Dani Megert

2009-02-25 04:38:18 EST

Comment on attachment 126672 [details]
Had left out calls to setFont in createDialogArea(). Removed them now.

There are still calls left.

Comment 7 Raksha Vasisht

2009-02-25 05:07:17 EST

Created attachment 126693 [details]
Added ConfigureWorkingSetAssignementAction dialog changes as well.

Comment 8 Dani Megert

2009-02-25 05:34:47 EST

Thanks for the patch.

Fixed in HEAD.
Available in builds > N20090224-2000.