Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 265564 - Signing (and conditioning) during publish
Summary: Signing (and conditioning) during publish
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-19 17:53 EST by Andrew Niefer CLA
Modified: 2017-01-21 17:33 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2009-02-19 17:53:19 EST 
Build currently supports signing (and to some degree pack200 conditioning) during the build.  This is necessary for JNLP builds.

When publishing from source, we are publishing directly into a p2 repository.
We either need to sign and condition during the publish, or have a publisher action that goes over a repo and signs/conditions it.

Build currently extends the JarProcessor to support using ant for signing, as well as unsigning, and conditioning.
Comment 1 Andrew Niefer CLA 2009-02-20 16:30:26 EST 
I've started this, code is currently in org.eclipse.equinox.p2.repository.tools

it is a task that conditions a repo (sign/pack) and updates the artifacts.xml
Comment 2 Andrew Niefer CLA 2009-02-20 19:10:19 EST 
Done. 
The ant task eclipse.jarProcessor is moved from pde.build to org.eclipse.equinox.p2.jarprocessor.  It supports signing using the ant sign task.

There is a new task p2.process.artifacts provided by org.eclipse.equinox.p2.repository.tools
This task has the form
<p2.process.artifacts 
               repositoryPath="file:/path/repo" 
               pack="true"       (optional)
               normalize="true"  (optional)
     <sign keystore="/path/keystore"
           keypass="keypass"
           storepass="storepass"
           alias="alias"
           unsign="true" />
</p2.process.artifacts>

The p2.process.artifacts task delegates to the eclipse.jarProcessor task for signing and packing.  The task will do the right thing wrt to conditioning and signing.  The unsign attribute indicates that any existing signatures should be removed from the jar.

I raised bug 265726 to change pde.build to use this task to sign when publishing from source.