Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 265491 - [Net] Redundant setProxiesEnabled() or bug?
Summary: [Net] Redundant setProxiesEnabled() or bug?
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-19 12:29 EST by Stefan Liebig CLA
Modified: 2009-06-03 16:26 EDT (History)
1 user (show)

See Also:

Attachments
Patch_v01 (905 bytes, patch)
2009-02-20 05:41 EST, Pawel Pogorzelski CLA 		john.arthorne: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Liebig CLA 2009-02-19 12:29:47 EST 
While working on another bug (Bug #262831) I went through
org.eclipse.core.internal.net.ProxySelector.setDefaultProvider(String)
and I was wondering if these lines are correct or if there is at least a redundancy:
	if (provider.equals(DIRECT_PROVIDER)) {
		service.setProxiesEnabled(false);
		service.setProxiesEnabled(false);
	} ..

Sorry, if this redundancy is intentional.
Comment 1 Pawel Pogorzelski CLA 2009-02-20 05:41:24 EST 
Created attachment 126270 [details]
Patch_v01
Comment 2 Pawel Pogorzelski CLA 2009-02-20 05:42:09 EST 
(In reply to comment #0)
> Sorry, if this redundancy is intentional.
> 

It isn't. Thanks for pointing this out.
Comment 3 Szymon Brandys CLA 2009-02-20 06:14:59 EST 
Released to HEAD. I renamed setDefaultProvider to setActiveProvider, so the name better reflects what the method actually does.