Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 265235 - Project reconcileLinks always delete's linked resource if resource contains a variable
Summary: Project reconcileLinks always delete's linked resource if resource contains a...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.5   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-17 19:06 EST by James Blackburn CLA
Modified: 2009-02-23 06:54 EST (History)
1 user (show)

See Also:

Attachments
Patch 1 (1.22 KB, patch)
2009-02-17 19:06 EST, James Blackburn CLA 		Szymon.Brandys: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Blackburn CLA 2009-02-17 19:06:21 EST 
Created attachment 125960 [details]
Patch 1

Build ID: 3.5

Steps To Reproduce:
As per bug 229633 comment 44.

This issue is present in the current platform.  Attached is a trivial patch to compare the new link with the RawLocationURI (rather than Location URI).

Szymon / John, can you review?
Comment 1 Szymon Brandys CLA 2009-02-20 08:46:46 EST 
James, the patch looks good. Let me write some tests, then I release it.
Comment 2 Szymon Brandys CLA 2009-02-23 06:07:50 EST 
While creating tests I noticed one more issue. See bug 265810.
Comment 3 Szymon Brandys CLA 2009-02-23 06:42:48 EST 
I released the fix to HEAD. I found it difficult to write a test case for that issue. Since the delete is nested, there is no event and I don't know how I could verify that the resource (with a path) was deleted temporarily.

Thanks James.
Comment 4 James Blackburn CLA 2009-02-23 06:44:44 EST 
Thanks for taking a look Szymon!

(In reply to comment #3)
> I released the fix to HEAD. I found it difficult to write a test case for that
> issue. Since the delete is nested, there is no event and I don't know how I
> could verify that the resource (with a path) was deleted temporarily.

Same here... It's very easy to see in the debugger though - and the fix is almost 'trivial' :).
Comment 5 Szymon Brandys CLA 2009-02-23 06:54:58 EST 
(In reply to comment #4)
> Thanks for taking a look Szymon!
> 
> (In reply to comment #3)
> > I released the fix to HEAD. I found it difficult to write a test case for that
> > issue. Since the delete is nested, there is no event and I don't know how I
> > could verify that the resource (with a path) was deleted temporarily.
> 
> Same here... It's very easy to see in the debugger though - and the fix is
> almost 'trivial' :).

Right, I could verify it only via the dubbuger. I always try to write some tests for fixed issues, otherwise I have a guilty feeling ;-)