Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 265232 - [CSS] CTabFolder extended properties are missing retrieveCSSProperty()
Summary: [CSS] CTabFolder extended properties are missing retrieveCSSProperty()
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.1   Edit
Assignee: Aghiles Abdesselam CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-17 18:42 EST by Kevin McGuire CLA
Modified: 2011-05-17 16:23 EDT (History)
0 users

See Also:

Attachments
retrieveCSSProperty() does not only return null (10.46 KB, patch)
2009-02-23 10:20 EST, Aghiles Abdesselam CLA 		no flags Details | Diff
retrieveCSSProperty() does not only return null & junit test (17.42 KB, patch)
2009-02-23 12:58 EST, Aghiles Abdesselam CLA 		john.arthorne: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2009-02-17 18:42:05 EST 
The recently added CTabFolder extended properties all return null for retrieveCSSProperty().

They must return the state of the property.  I believe this is required for certain cases where a snapshot of the existing widget state is required (e.g. to restore it to the state prior to styling).
Comment 1 Aghiles Abdesselam CLA 2009-02-23 10:20:47 EST 
Created attachment 126462 [details]
retrieveCSSProperty() does not only return null
Comment 2 Kevin McGuire CLA 2009-02-23 11:37:03 EST 
(In reply to comment #1)
> Created an attachment (id=126462) [details]
> retrieveCSSProperty() does not only return null

Please also attach junit tests.
Comment 3 Aghiles Abdesselam CLA 2009-02-23 12:58:55 EST 
Created attachment 126485 [details]
retrieveCSSProperty() does not only return null & junit test
Comment 4 Kevin McGuire CLA 2009-02-23 22:12:03 EST 
Instead of:
	if (folder.getBorderVisible())
		return "true";
	else
		return "false";

You could do:

	return Boolean.toString(folder.getBorderVisible());

which is a little more compact, less prone to typo or copy/paste error, and more importantly will return the correct String representation for true/false.
Comment 5 Kevin McGuire CLA 2009-02-23 22:44:34 EST 
Released to HEAD