Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 265231 - [templates] Update "RCP application with a view" with commands
Summary: [templates] Update "RCP application with a view" with commands
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 enhancement with 4 votes (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-17 18:28 EST by Lars Vogel CLA
Modified: 2009-10-27 17:28 EDT (History)
6 users (show)

See Also:


Attachments
patchViewRCPTemplate.txt (3.30 KB, text/plain)
2009-02-19 17:02 EST, Lars Vogel CLA
caniszczyk: iplog+
Details
patchApplicationActionBarAdvisor.txt (1.53 KB, text/plain)
2009-02-19 17:02 EST, Lars Vogel CLA
caniszczyk: iplog+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2009-02-17 18:28:25 EST
Build ID: M20080911-1700

Steps To Reproduce:
Build ID: M20080911-1700

Steps To Reproduce:
Hi, 

I suggest to use a menu extention and the command "org.eclipse.ui.file.exit" for File -> Exit rather then the Exit Action in the "RCP application with a view" template. 

I believe the changes to the template is trivial, if desired I can try to provide them as a patch (if you point me to CVS repository for the template). 


More information:
I believe this is not the same as https://bugs.eclipse.org/bugs/show_bug.cgi?id=253105
Comment 1 Chris Aniszczyk CLA 2009-02-17 18:52:21 EST
dev.eclipse.org
/cvsroot/eclipse
pde/ui/org.eclipse.pde.ui.templates

How about that?
Comment 2 Lars Vogel CLA 2009-02-19 17:02:07 EST
Created attachment 126228 [details]
patchViewRCPTemplate.txt
Comment 3 Lars Vogel CLA 2009-02-19 17:02:34 EST
Created attachment 126229 [details]
patchApplicationActionBarAdvisor.txt
Comment 4 Lars Vogel CLA 2009-02-19 17:03:02 EST
Hi Chris,

Attached the following patches:

- org.eclipse.pde.internal.ui.templates.rcp.ViewRCPTemplate: patchViewRCPTemplate.txt

Adds the menu contribution


- ApplicationActionBarAdvisor.java from templates_3.3/viewRCP/java
patchApplicationActionBarAdvisor.txt

- Removes the action

I believe it is also necessary to make a copy of templates_3.3 to templates_3.5 and to patch PDETemplateSection method getDirectoryCandidates() to consider the new template directory.

This is new first attempt to provide a patch to Eclipse so if you see issues this my patches please let me know.

Best regards, Lars


Comment 5 Lars Vogel CLA 2009-05-04 16:19:59 EDT
Update: I also believe it would be preferable to use the perspective extension for adding the view. I believe this is also in line with http://rcpquickstart.com/2008/12/11/perspective-layouts-programmatic-vs-declarative/

If you indicate that this change would be desired I can update the patch.

Comment 6 Mike Wilson CLA 2009-05-05 13:35:06 EDT
Changing Version tag to something more believable.
Comment 7 Lars Vogel CLA 2009-07-29 17:07:05 EDT
Looks like your considering changing the template. Fantastic! 

Let me know if I should change anything in the patches. 
Comment 8 Chris Aniszczyk CLA 2009-09-22 16:45:31 EDT
done.

> 20090922

Thanks for your contribution!
Comment 9 Curtis Windatt CLA 2009-10-27 17:28:28 EDT
Verified.