This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 265080 - [context] can't make a *.textile file a landmark
Summary: [context] can't make a *.textile file a landmark
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 1.0.0   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-17 01:38 EST by David Green CLA
Modified: 2011-01-06 10:01 EST (History)
2 users (show)

See Also:


Attachments
mylyn/context/zip (855 bytes, application/octet-stream)
2009-02-17 01:39 EST, David Green CLA
no flags Details
fix (947 bytes, patch)
2009-03-05 21:12 EST, David Green CLA
no flags Details | Diff
mylyn/context/zip (1.11 KB, application/octet-stream)
2009-03-05 21:12 EST, David Green CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Green CLA 2009-02-17 01:38:17 EST
When attempted Mylyn responds with "Not a valid landmark, select an element within this resource instead".

Users should be able to make *.textile, *.confluence, *.mediawiki etc. landmarks.
Comment 1 David Green CLA 2009-02-17 01:39:53 EST
Created attachment 125853 [details]
mylyn/context/zip
Comment 2 Mik Kersten CLA 2009-02-17 14:16:47 EST
It would be good to have this for 3.2.  We might need at least a minimal structure and UI bridge for Textile.
Comment 3 David Green CLA 2009-02-18 00:47:42 EST
(In reply to comment #2)
> It would be good to have this for 3.2.  We might need at least a minimal
> structure and UI bridge for Textile.

A UI and structure bridge already exist in org.eclipse.mylyn.internal.wikitext.tasks.ui, they were created to support active folding in the editor (bug 260475).  Could be a bug in their implementation... any ideas on how to fix this issue?
Comment 4 Mik Kersten CLA 2009-02-18 19:40:40 EST
By default files can't be landmarks if a bridge supports structure under the file.  Does textile support that?
Comment 5 David Green CLA 2009-02-18 20:54:12 EST
Yes, WikiText files have structure under the file.  The structure is computed from the headings in the document and is used to drive active folding in the editor and interest-based filtering in the outline view.

Is there a way for bridges to alter this default behaviour?
Comment 6 David Green CLA 2009-02-19 18:52:15 EST
I'm looking for guidance on this one when you have a chance.
Comment 7 Mik Kersten CLA 2009-02-26 22:33:06 EST
Does the structure under the file node show in the Project Explorer?  If so, the current design is that the files should not be allowed to become landmarks (see bug 111165).  
Comment 8 David Green CLA 2009-02-26 23:14:33 EST
(In reply to comment #7)
> Does the structure under the file node show in the Project Explorer? 

No, the file node doesn't show structure in the Project Explorer

Comment 9 Mik Kersten CLA 2009-02-27 16:34:22 EST
Please add this as a discussion item for an upcoming meeting.
Comment 10 David Green CLA 2009-03-05 21:12:55 EST
Created attachment 127740 [details]
fix

Mik: turns out that this is a trivial change to @canBeLandmark(String)@ in @WikiTextContextStructureBridge@.  Can you review this patch?  If it looks good to you I'd like to have it in 3.1
Comment 11 David Green CLA 2009-03-05 21:12:57 EST
Created attachment 127742 [details]
mylyn/context/zip
Comment 12 Mik Kersten CLA 2009-03-10 16:21:45 EDT
Yes, that's fine.  I assume that your bridge is a child of the resource structure bridge?
Comment 13 David Green CLA 2009-03-10 16:35:31 EDT
(In reply to comment #12)
> Yes, that's fine.  I assume that your bridge is a child of the resource structure bridge?

Super.  Yes, it's a child of the resource structure bridge.