Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 264720 - Remove duplicate creation of comparator in WorkingSetConfigurationDialog
Summary: Remove duplicate creation of comparator in WorkingSetConfigurationDialog
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Raksha Vasisht CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-12 12:06 EST by Dani Megert CLA
Modified: 2009-02-13 07:32 EST (History)
0 users

See Also:

Attachments
Patch with the working set comparator instance stored as a field. (2.36 KB, patch)
2009-02-13 06:11 EST, Raksha Vasisht CLA 		no flags Details | Diff
Fixed lazy loading, minor changes. (2.24 KB, patch)
2009-02-13 07:28 EST, Raksha Vasisht CLA 		daniel_megert: iplog+
daniel_megert: review+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2009-02-12 12:06:02 EST 
N20090212-2000.

Remove duplicate creation of comparator in WorkingSetConfigurationDialog: create a getComparator() which lazily creates it and stores it in a field.
Comment 1 Raksha Vasisht CLA 2009-02-13 06:11:57 EST 
Created attachment 125620 [details]
Patch with the working set comparator instance stored as a field.
Comment 2 Raksha Vasisht CLA 2009-02-13 07:28:41 EST 
Created attachment 125624 [details]
Fixed lazy loading, minor changes.
Comment 3 Dani Megert CLA 2009-02-13 07:31:38 EST 
Thanks for the patch Raksha.

Fixed in HEAD.
Available in builds > N20090212-2000.