Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 264526 - SimpleArtifactRepository leaves temporary file when unzip fails
Summary: SimpleArtifactRepository leaves temporary file when unzip fails
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-11 10:07 EST by Matthew Piggott CLA
Modified: 2009-02-11 14:04 EST (History)
1 user (show)

See Also:

Attachments
Patch to ensure the removal of temp file (1.05 KB, patch)
2009-02-11 10:07 EST, Matthew Piggott CLA 		pascal: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Piggott CLA 2009-02-11 10:07:31 EST 
Created attachment 125394 [details]
Patch to ensure the removal of temp file

The SimpleArtifactRepository inner class ZippedFolderOutputStream automatically attempts to unzip its temporary file, if unzip fails (the file is empty or invalid for example) the temp file is never removed.  The patch simply adds a try {unzip} finally {delete}.
Comment 1 Pascal Rapicault CLA 2009-02-11 14:04:57 EST 
Released in HEAD