Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 264413 - [target] Broken buttons on plug-in import wizard (source code locations & environment)
Summary: [target] Broken buttons on plug-in import wizard (source code locations & env...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 207861 266088 (view as bug list)
Depends on: 266880
Blocks:
  Show dependency tree
 
Reported: 2009-02-10 14:51 EST by Darin Wright CLA
Modified: 2009-04-17 16:52 EDT (History)
4 users (show)

See Also:
curtis.windatt.public: review+

Attachments
patch (22.61 KB, patch)
2009-02-27 16:57 EST, Darin Wright CLA 		no flags Details | Diff
patch (21.23 KB, patch)
2009-02-27 17:02 EST, Darin Wright CLA 		no flags Details | Diff
update (29.67 KB, patch)
2009-03-02 10:45 EST, Darin Wright CLA 		no flags Details | Diff
because we love backwards compatibility.... (51.93 KB, patch)
2009-03-02 13:14 EST, Darin Wright CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2009-02-10 14:51:37 EST 
The plug-in import wizard has two buttons that link to old target platform prefenence page settings (source locations and environment). We need these to work properly with the new preference page.
Comment 1 Darin Wright CLA 2009-02-27 16:57:35 EST 
Created attachment 127052 [details]
patch

Work in progress. Allows to import from the active target, a specific target, or from a directory.

Source attachments are busted when importing from something other than the current target platform (as they always have been... the source attachments come only from the active target platform source locations).
Comment 2 Darin Wright CLA 2009-02-27 17:02:34 EST 
Created attachment 127053 [details]
patch

Previous patch had unwanted change in it.
Comment 3 Darin Wright CLA 2009-03-02 10:45:16 EST 
Created attachment 127169 [details]
update

Fixed source attachements when importing from a location that is not the active target platform. Allows for alternate source locations.
Comment 4 Darin Wright CLA 2009-03-02 13:14:21 EST 
Created attachment 127198 [details]
because we love backwards compatibility....

This patch also supports old style source plug-ins. Yay (not) !
Comment 5 Darin Wright CLA 2009-03-02 14:00:19 EST 
*** Bug 266088 has been marked as a duplicate of this bug. ***
Comment 6 Darin Wright CLA 2009-03-02 14:31:18 EST 
Cleaned up progress reporting, released to HEAD.
Comment 7 Darin Wright CLA 2009-03-02 14:31:42 EST 
Please verify, Curtis.
Comment 8 Curtis Windatt CLA 2009-03-03 11:37:50 EST 
Filed bug 266880, this must be fixed before I will verify.
Comment 9 Curtis Windatt CLA 2009-03-03 16:58:34 EST 
Verified.
Comment 10 Curtis Windatt CLA 2009-03-16 12:07:18 EDT 
*** Bug 207861 has been marked as a duplicate of this bug. ***
Comment 11 Curtis Windatt CLA 2009-03-16 12:46:14 EDT 
*** Bug 239366 has been marked as a duplicate of this bug. ***
Comment 12 Curtis Windatt CLA 2009-04-17 16:52:58 EDT 
+1 review wasn't recorded properly.