Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 264288 - New Plugin Project Wizard allows % in project name
Summary: New Plugin Project Wizard allows % in project name
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.5 M6   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-09 20:41 EST by Erkki Lindpere CLA
Modified: 2009-02-09 22:14 EST (History)
1 user (show)

See Also:
curtis.windatt.public: iplog+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erkki Lindpere CLA 2009-02-09 20:41:29 EST 
I am not sure if this is intended or not, but the New Plugin Project Wizard allows a project name to start with "%". There seems to be a simple mistake in the way PDE checks if the name doesn't contain '%':

if (name.indexOf('%') > 0)

should be

if (name.indexOf('%') > -1)

Same for location.indexOf ... Lines 220 and 226 (in 3.4)

Somehow I manage to find these really minor bugs :)
Comment 1 Curtis Windatt CLA 2009-02-09 22:14:46 EST 
Fixed in HEAD.  

I'm going to add the IP Log flag to this since you pointed out the exact lines and changes that need to be made.  It is easier to track contributions if you make a patch though.

Thanks!