Community
Participate
Working Groups
Created attachment 125097 [details] Implementation of photran fortran search functionality The attached patch implements searching for particular Fortran identifiers in Photran, a la the Java and CDT search functionality. The was completed as part of CS427 (Software Engineering I), Fall, 2008, under the guidance of Yun Young Lee and Prof. Ralph Johnson, as the final project for team Quillback, consisting of: Jeff Dammeyer <jdammey2@uiuc.edu> Andrew Deason <adeason2@uiuc.edu> Nick Sexmith <sexmith2@uiuc.edu> Joe Digiovanna <jdigiov2@uiuc.edu> The patch is against a non-current CVS HEAD. It wasn't a particular version, but it looks like it was checked out on 31 Oct 2008, 3:32 AM, at least on my local machine.
Could you please make fsearch_obj.gif a separate attachment on this bug? Thanks.
Created attachment 125682 [details] fortran search logo Yeah, I was wondering if that would work at all as just part of a patch. Attached now; it's just the little icon for the search page.
Andrew, Can you please confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files? For #1, I believe you borrowed some content from CDT, so you will want to note that. For the purposes of our legal review, I should note that, according to the University's policy, you and your co-authors are the exclusive copyright holders because this was a class project. Thanks. Jeff
Submitted CQ 3103 https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3103
> Can you please confirm that > > 1. you wrote 100% of the code without incorporating content from elsewhere or > relying on the intellectual property of others, There is the exception of CDT that you mentioned, which is noted in the comments of VPGSearchPage.java (the affected file). Sans that, to the best of my knowledge I can confirm, yes. > 2. you have the right to contribute the code to Eclipse, and Yes. > 3. you have included the EPL license header in all source files? Yes, with the exception of test files. Other preexisting tests also lack it.
(In reply to comment #3) > Andrew, > > Can you please confirm that > > 1. you wrote 100% of the code without incorporating content from elsewhere or > relying on the intellectual property of others, > Aside of CDT, yes. > 2. you have the right to contribute the code to Eclipse, and > Yes. > 3. you have included the EPL license header in all source files? > Yes. > For #1, I believe you borrowed some content from CDT, so you will want to note > that. > > For the purposes of our legal review, I should note that, according to the > University's policy, you and your co-authors are the exclusive copyright > holders because this was a class project. > > Thanks. > Jeff >
(In reply to comment #3) > Andrew, > > Can you please confirm that > > 1. you wrote 100% of the code without incorporating content from elsewhere or > relying on the intellectual property of others, Excetping CDT, yes. > 2. you have the right to contribute the code to Eclipse, and Yes. > 3. you have included the EPL license header in all source files? Yes. > For #1, I believe you borrowed some content from CDT, so you will want to note > that. > > For the purposes of our legal review, I should note that, according to the > University's policy, you and your co-authors are the exclusive copyright > holders because this was a class project. > > Thanks. > Jeff >
> Andrew, > > Can you please confirm that > > 1. you wrote 100% of the code without incorporating content from elsewhere or > relying on the intellectual property of others, > With the exception of CDT, yes. > 2. you have the right to contribute the code to Eclipse, and > Yes. > 3. you have included the EPL license header in all source files? > Yes. > For #1, I believe you borrowed some content from CDT, so you will want to note > that. > > For the purposes of our legal review, I should note that, according to the > University's policy, you and your co-authors are the exclusive copyright > holders because this was a class project. > > Thanks. > Jeff >
A couple notes to myself... After I apply the patch, 1. The documentation (and parameter name) for Definition#matches should be update to reflect the API change (it now matches against a regex) 2. testFour fails because it does not find the declaration of an implicit variable, which is also a reference 3. Will about.html need to change?
Created attachment 139718 [details] New version of previous patch New version of the photran search functionality patch. Includes hopefully more clear / palatable licenses and copyright notices.
Thanks a lot, Andrew. --Jeff
This passed the IP review. I'm committing it to CVS; it will be in the next build. Thanks again.
For the record, these are my notes from this group's final presentation in 427... Quillback - Fortran Search (17 Dec 2008) - Patterns are remembered but not other dialog settings - VPGSearchMatch eliminates duplicates due to equals() - Line 165 in VPGSearchQuery - resource visitor tries to parse all files, will succeed on any Fortran file it can parse since acquireTransient does not check content type - Compare VPGSearchPage to PDOM equivalent - Change to matches due to manuallyResolve call chain using it - Why does manuallyResolve return tokens with offset/length < 0? - VPGSearchQuery lines 2xx -- some helper methods did not exist - PDOMSearchPage 527 selects type/flags in dialog based on selection
This was in the latest integration build, no problems. Closing it out. Thanks again.
