Community
Participate
Working Groups
Using Eclipse 3.5 M5. The "Target Platform (experimental)" preference page gathers all the targets that exist in the .metadata and the workspace. Unfortunately, the UI does not always show where the targets reside, and clicking the "Remove" button physically deletes the files, rather than just removing it from the list of managed targets. The downside of this is that a file from the workspace can be lost without the user realizing it. Some suggestions: 1. Show in the UI where the target file resides: - For those that reside in the .metadata you could just say something like "Private" or "Internal", or some such word. - For those that reside in the workspace, the workspace's relative path would suffice. - And if/when in the future targets can reside in the local file system, but outside of the workspace, the absolute path should be shown. 2. Creating a target is not necessarily trivial, so please consider adding a confirmation dialog to the "Remove" behavior. - This will help prevent accidental deletion, somewhat. - To delete a target that resides in either the workspace or the local file system the dialog should contain a checkbox that the user is required to check before the .target file is really deleted. This is just like when you delete a Project from the workspace. - You could add a "Don't ask me again" checkbox for those that find it annoying. Although I'm not convinced that this is a good thing.
> Show in the UI where the target file resides: The pref page now shows were workspace definitions reside with workspace relative paths using a styled label provider. We should prompt the user when removing target definitions with a "don't ask again" check box. (I suppose "don't ask again" preference setting for this could be on the same page). The prompt should explain that this will delete files.
(In reply to comment #1) > We should prompt the user when removing target definitions with a "don't ask > again" check box. (I suppose "don't ask again" preference setting for this > could be on the same page). The prompt should explain that this will delete > files. > As much as I don't like having more controls on the page, we do need to prompt before deleting files from the workspace. Ankur, if you want to work on this, a similar dialog can be seen by going to the run/debug drop down icons that show a list of recent launch configs. If you hold down Ctrl and Shift then click on one, we will remove it, but prompts your first. The checkbox can be reset using the Run/Debug > Launching preference page ("Prompt for confirmation before removing...").
Created attachment 131846 [details] Patch Added a confirmation dialog on Remove. The setting for prompt persisted in the store. Added check box to MainPreferencePage to control it. And Some code to keep the pref page and dialog behaviour in sync.
Made a couple changes: Now it only prompts if we are deleting a workspace file (Might have to update this when I look at the external files). Updated the text to reflect the above change Fixed the return code logic, hitting cancel was the same as hitting yes. Fixed in HEAD.
