Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 264052 - [templates] new SWT templates - ToolBar and ToolItem
Summary: [templates] new SWT templates - ToolBar and ToolItem
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Benno Baumgartner CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-07 16:40 EST by Benjamin Muskalla CLA
Modified: 2009-02-10 07:03 EST (History)
1 user (show)

See Also:
benno.baumgartner: review+

Attachments
patch (3.00 KB, patch)
2009-02-08 17:35 EST, Benjamin Muskalla CLA 		daniel_megert: iplog+
benno.baumgartner: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2009-02-07 16:40:23 EST 
N20090205-2000

I think it's useful to have SWT templates for ToolBar and ToolItems
Comment 1 Dani Megert CLA 2009-02-08 12:22:57 EST 
Patch welcome ;-)
Comment 2 Benjamin Muskalla CLA 2009-02-08 17:35:28 EST 
Created attachment 125084 [details]
patch

Here we go ;-)
Comment 3 Dani Megert CLA 2009-02-09 04:45:10 EST 
Benno, can you please review? Thanks.
Comment 4 Benno Baumgartner CLA 2009-02-10 04:45:01 EST 
Fixed > I20090203-1200

Thank you Benjamin.

Dani, I don't have access to the contributor DB anymore...
Comment 5 Dani Megert CLA 2009-02-10 06:54:51 EST 
>Dani, I don't have access to the contributor DB anymore...
Done.

Benno, more important than adding the entry there is to set the iplog flag on the patch to '+'. The 'contributed' keyword is no longer used.
Comment 6 Dani Megert CLA 2009-02-10 07:00:33 EST 
Benny (and Benno ;-) next time please don't forget to
- update the copyright date
- add the copyright entry to *all* files
- use this pattern for the entry:
Real Full Name <e-mail> - bug summary from bugzilla - full URL
e.g.
Benjamin Muskalla <bmuskalla@eclipsesource.com> - [templates] new SWT templates - ToolBar and ToolItem - https://bugs.eclipse.org/bugs/show_bug.cgi?id=264052

Thanks.