Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 263523 - [cocoa] Incorrect colors for eclipse splash screen in 3.5m5
Summary: [cocoa] Incorrect colors for eclipse splash screen in 3.5m5
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-03 14:23 EST by Ketan Padegaonkar CLA
Modified: 2009-03-06 14:32 EST (History)
7 users (show)

See Also:

Attachments
screenshot of the splash screen (142.34 KB, image/png)
2009-02-03 14:24 EST, Ketan Padegaonkar CLA 		no flags Details
Patch (1.54 KB, patch)
2009-02-05 16:51 EST, Kevin Barnes CLA 		aniefer: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ketan Padegaonkar CLA 2009-02-03 14:23:17 EST 
+++ This bug was initially created as a clone of Bug #263518 +++

The splash screen shows up a gray progress bar, while the rest of eclipse shows a blue progress bar.
Comment 1 Ketan Padegaonkar CLA 2009-02-03 14:24:29 EST 
Created attachment 124593 [details]
screenshot of the splash screen
Comment 2 Felipe Heidrich CLA 2009-02-04 10:06:58 EST 
Kevin, please fix it or reassign it to Andrew
Comment 3 Kevin Barnes CLA 2009-02-05 09:19:45 EST 

*** This bug has been marked as a duplicate of bug 263518 ***
Comment 4 Kevin Barnes CLA 2009-02-05 12:44:26 EST 
Reopening. This is caused by the splash screens window not being the key window.
Comment 5 Kevin Barnes CLA 2009-02-05 12:50:41 EST 
brought the sexy back > 20090205
Comment 6 Kevin Barnes CLA 2009-02-05 16:44:39 EST 
I don't like this fix. The bug is really in the launcher. The shell that the launcher creates needs to be able to become the key window. If it cannot, the controls inside the shell appear disabled.
Comment 7 Kevin Barnes CLA 2009-02-05 16:51:17 EST 
Created attachment 124890 [details]
Patch

Need to subclass NSWindow so that we can over ride 
- (BOOL)canBecomeKeyWindow
Comment 8 Scott Kovatch CLA 2009-02-05 20:02:15 EST 
(In reply to comment #7)
> Created an attachment (id=124890) [details]
> Patch
> 
> Need to subclass NSWindow so that we can over ride 
> - (BOOL)canBecomeKeyWindow
> 

This is the right fix. By default an NSWindow without borders or trim returns NO for canBecomeKeyWindow, so overriding this is the way to go.
Comment 9 Kevin Barnes CLA 2009-03-02 18:46:38 EST 
Would be nice to have this for EclipseCon. Any chance of this patch making it into m6?
Comment 10 Andrew Niefer CLA 2009-03-06 14:31:20 EST 
fixed and recompiled.  This affects the shared library and not the exe.
org.eclipse.equinox.launcher.cocoa.macosx
org.eclipse.equinox.launcher.cocoa.macosx.x86_64