Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 263514 - Support docshare in certain multi-page editors
Summary: Support docshare in certain multi-page editors
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.cola (show other bugs)
Version: 3.0.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Marcelo Mayworm CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 264247
  Show dependency tree
 
Reported: 2009-02-03 14:05 EST by Nitin Dahyabhai CLA
Modified: 2009-05-29 14:47 EDT (History)
4 users (show)

See Also:
mayworm: iplog+


Attachments
patch (6.79 KB, patch)
2009-02-03 14:05 EST, Nitin Dahyabhai CLA
slewis: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2009-02-03 14:05:23 EST
Created attachment 124590 [details]
patch

3.0.0.v20090127-1900

DocShare collaboration is terrific, but it's limited to ITextEditor parts.  One idiom that we've adopted in WTP, and our adopter product, is to allow a mutli-page editor which doesn't implement ITextEditor itself to return ITextEditor as an adapter, providing access to its source page (assuming it only has one such page, we never worked out the semantics beyond that).  Most of the time this is the actual editor part embedded as the source page, providing a straightforward way to enable support in editors like WTP's XML Editor.

I intend to add docshare to the WTP Source Editing M6 plan, but it would be a shame for our multi-page editors to not support this properly.  Patch attached adding the various calls in the DocShare plug-in to make use of this pattern, and remove an unnecessary restriction on its use with IFileEditorInput.
Comment 1 Marcelo Mayworm CLA 2009-02-05 17:29:35 EST
Thanks Nitin.

Scott, Mustafa and Nitin, I'm going to take a look at the patch...I will send comments here late.
Comment 2 Marcelo Mayworm CLA 2009-02-09 19:07:42 EST
The patch was applied, tested, and committed to HEAD.

Thanks Nitin for the contribution.