Community
Participate
Working Groups
In the "Install New Software" dialog, if you select an IU you can see details (and select "more" for more details, such as copyright, etc...) This "more" link is not available in the "Available Updates" dialog.
The update wizard has never shown properties (apart from the detail description) but perhaps it should... Agree that with the properties button changing to a "more..." link, the expectation is now there to see it everywhere.
Since I found it, I'll offer to fix it (unless you think this is an overly complex undertaking).
(In reply to comment #2) > Since I found it, I'll offer to fix it (unless you think this is an overly > complex undertaking). > it's not complex, but if we are going to go for consistency, then I think we should do it everywhere...ie, if the goal is to put a "More..." link in every detail area and have it open the properties, then we would want to see it in the first and second page of all three wizards (install/update/uninstall), as well as in the Installed Software page. And at that point it's probably worth having a little shared UI component around that does it rather than copying the code to 3 other places...
Created attachment 124340 [details] Add "more" details to all the detail panes I have created a single class for the details pane (that includes a more link) and then used this wherever the details pane is used. Let me know what you think of this approach.
Created attachment 124353 [details] Updated Patch After reviewing my code a little more, I realized that there were some "detail panes" that had scrollbars, while others didn't. I think this was because some also show error messages when the constraints cannot be resolved. I have updated the patch to keep the same behaviour (scrollbars where we had them before).
looking at this now. I've been hacking in the wizards and don't want this patch to get too stale...
if it's stale let me know, I can try and update it.
Incorporated patch. Thanks, I like it! Fixed in HEAD >20090219. I had never noticed the "More..." missing until you brought it up, and once I started looking at it, I hated when it didn't have it. Some changes I made - I realize you were trying to keep things flexible so the existing code would work the same. I took the liberty of being more restrictive - always enforcing the same margins, height, etc. So the caller only has to pass in the preferred width - I removed the scrollable option. The available IU group was changed to non-scrollable when I added the "more..." link. If the description is long, the user can press More... and read it in the prop dialog. So there's no need to preserve the old scrollable behavior, which was funny looking on some platform/color combinations inside that group. Much improved. - I changed the constructor to call groupComposite... so that it would be more like the AvailableIUGroup and InstalledIUGroup. - SelectableIUsPage wasn't priming the detail enablement according to initial selection or changing it in the callback. I added the enablement in the callback and decided that it's kind of cool for the group to set the initial enablement based on the selection provider's selection being not empty. The clients can still prime it themselves based on other criteria if they are more specific (such as resolution page). - While working on the about pages, I had to change the installed software page details area to get rid of the group so it would look right on the gradiated background of the tab folder. A group wouldn't work at all here. So this dialog is still "old style" with no group, scroll bars, and a Properties button.
(In reply to comment #8) <snip> > - I removed the scrollable option. The available IU group was changed to > non-scrollable when I added the "more..." link. If the description is long, > the user can press More... and read it in the prop dialog. So there's no need > to preserve the old scrollable behavior, which was funny looking on some > platform/color combinations inside that group. Much improved. Well, one potential problem I've introduced is when there is verbose error text in the details of the resolution page. In that case, the More... link is gone and the error text is typically long. However, you can still move the focus and scroll with the keyboard, or use the sash, or swipe/scroll. I kind of prefer this to the funny looking scrollbars so I'm not going to go back and add the scrollable option...let's see how it plays.
>I kind of > prefer this to the funny looking scrollbars so I'm not going to go back and add > the scrollable option...let's see how it plays. > See bug 266729, need to put the scrollbars back.
Changed IUDetailsArea so that clients can create it with the scrollable option. ResolutionWizardPage will use scrollable = true, others will not. The rule of thumb to use is that if the info shown in the details is always available in the properties dialog, such that the "More..." link is always shown, then scrollbars shouldn't be used. If a client is putting things in the details area that aren't related to properties, then the scrollbars might still be needed. fixed in HEAD >20090302.
