Community
Participate
Working Groups
I20090127-0100 1) Create a service component (component.xml) 2) Ensure all editors are closed 3) Open the component.xml with the service component editor 4) Close the editor Each time steps 3-4 are repeated, three images are leaked. The allocation traces look like this: java.lang.Error at org.eclipse.swt.graphics.Device.new_Object(Device.java:804) at org.eclipse.swt.graphics.Resource.init(Resource.java:85) at org.eclipse.swt.graphics.Image.<init>(Image.java:577) at org.eclipse.jface.resource.URLImageDescriptor.createImage(URLImageDescriptor.java:162) at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:227) at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:205) at org.eclipse.pde.internal.ui.editor.text.PDEQuickAssistAssistant.<init>(PDEQuickAssistAssistant.java:185) at org.eclipse.pde.internal.ui.editor.text.XMLConfiguration.getQuickAssistAssistant(XMLConfiguration.java:149) at org.eclipse.jface.text.source.SourceViewer.configure(SourceViewer.java:382) at org.eclipse.pde.internal.ui.editor.PDEProjectionViewer.configure(PDEProjectionViewer.java:91) at org.eclipse.ui.texteditor.AbstractTextEditor.createPartControl(AbstractTextEditor.java:3281) at org.eclipse.ui.texteditor.StatusTextEditor.createPartControl(StatusTextEditor.java:53) at org.eclipse.ui.texteditor.AbstractDecoratedTextEditor.createPartControl(AbstractDecoratedTextEditor.java:398) at org.eclipse.pde.internal.ui.editor.PDESourcePage.createPartControl(PDESourcePage.java:271) at org.eclipse.pde.internal.ui.editor.PDEProjectionSourcePage.createPartControl(PDEProjectionSourcePage.java:46) at org.eclipse.ui.part.MultiPageEditorPart.addPage(MultiPageEditorPart.java:236) at org.eclipse.ui.forms.editor.FormEditor.addPage(FormEditor.java:319) at org.eclipse.ui.part.MultiPageEditorPart.addPage(MultiPageEditorPart.java:206) at org.eclipse.ui.forms.editor.FormEditor.addPage(FormEditor.java:302) at org.eclipse.pde.internal.ui.editor.MultiSourceEditor.addSourcePage(MultiSourceEditor.java:30) at org.eclipse.pde.internal.ds.ui.editor.DSEditor.addEditorPages(DSEditor.java:51) at org.eclipse.pde.internal.ui.editor.PDEFormEditor.addPages(PDEFormEditor.java:948) at org.eclipse.ui.forms.editor.FormEditor.createPages(FormEditor.java:138) at org.eclipse.pde.internal.ui.editor.PDEFormEditor.createPages(PDEFormEditor.java:244) at org.eclipse.ui.part.MultiPageEditorPart.createPartControl(MultiPageEditorPart.java:329) at org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:678) at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:444) at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:595) at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:313) at org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:180) at org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select(PresentablePartFolder.java:270) at org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select(LeftToRightTabOrder.java:65) at org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart(TabbedStackPresentation.java:473) at org.eclipse.ui.internal.PartStack.refreshPresentationSelection(PartStack.java:1256) at org.eclipse.ui.internal.PartStack.setSelection(PartStack.java:1209) at org.eclipse.ui.internal.PartStack.showPart(PartStack.java:1608) at org.eclipse.ui.internal.PartStack.add(PartStack.java:499) at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:103) at org.eclipse.ui.internal.PartStack.add(PartStack.java:485) at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:112) at org.eclipse.ui.internal.EditorSashContainer.addEditor(EditorSashContainer.java:63) at org.eclipse.ui.internal.EditorAreaHelper.addToLayout(EditorAreaHelper.java:225) at org.eclipse.ui.internal.EditorAreaHelper.addEditor(EditorAreaHelper.java:213) at org.eclipse.ui.internal.EditorManager.createEditorTab(EditorManager.java:782) at org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor(EditorManager.java:681) at org.eclipse.ui.internal.EditorManager.openEditor(EditorManager.java:642) at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2848) at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2760) at org.eclipse.ui.internal.WorkbenchPage.access$11(WorkbenchPage.java:2752) at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.java:2704) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70) at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2699) at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2683) at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2674) at org.eclipse.ui.ide.IDE.openEditor(IDE.java:646) at org.eclipse.ui.ide.IDE.openEditor(IDE.java:605) at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:340) at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:164) at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:229) at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:208) at org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchRun(SelectionDispatchAction.java:274) at org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(SelectionDispatchAction.java:250) at org.eclipse.jdt.internal.ui.navigator.OpenAndExpand.run(OpenAndExpand.java:49) at org.eclipse.ui.actions.RetargetAction.run(RetargetAction.java:221) at org.eclipse.ui.navigator.CommonNavigatorManager$3.open(CommonNavigatorManager.java:202) at org.eclipse.ui.OpenAndLinkWithEditorHelper$InternalListener.open(OpenAndLinkWithEditorHelper.java:48) at org.eclipse.jface.viewers.StructuredViewer$2.run(StructuredViewer.java:829) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37) at org.eclipse.core.runtime.Platform.run(Platform.java:874) at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:48) at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175) at org.eclipse.jface.viewers.StructuredViewer.fireOpen(StructuredViewer.java:827) at org.eclipse.jface.viewers.StructuredViewer.handleOpen(StructuredViewer.java:1088) at org.eclipse.ui.navigator.CommonViewer.handleOpen(CommonViewer.java:390) at org.eclipse.jface.viewers.StructuredViewer$6.handleOpen(StructuredViewer.java:1192) at org.eclipse.jface.util.OpenStrategy.fireOpenEvent(OpenStrategy.java:264) at org.eclipse.jface.util.OpenStrategy.access$2(OpenStrategy.java:258) at org.eclipse.jface.util.OpenStrategy$1.mouseSelectItem(OpenStrategy.java:429) at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:365) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3875) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3470) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2388) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2352) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2204) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:499) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:333) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:492) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:615) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:550) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:505) at org.eclipse.equinox.launcher.Main.run(Main.java:1264)
Created attachment 123936 [details] patch A little refactoring later, here we are... Thanks John for having reported this leak!
Created attachment 123937 [details] mylyn/context/zip
Thanks for the catch John.
done. > 20090208 Thanks for the patch Benjamin again. I like when refactoring removes an old class.
