Community
Participate
Working Groups
When an intersects is performed on raw Versions the test for version equality fails. Lines 87-88 in VersionRange.java should read like this: else if (!(minVersion.getFormat() == null ? maxVersion.getFormat() == null : minVersion.getFormat().equals(maxVersion.getFormat()))) throw new IllegalArgumentException(NLS.bind(Messages.range_boundaries_0_and_1_cannot_have_different_formats, minVersion, maxVersion)); Don't know if this has been fixed in a yet uncommitted patch - I am happy to provide a patch for it otherwise. Tested in eclipse-SDK-I20090122-0800-macosx-carbon There is also a problem in that the intersect test is not added to AllTests, so it only runs on demand - that is probably why this bug slipped in. (I am happy to patch that too)
There is also an error in IntersectText.testPartialEqualUpper the test is wrong.
You are the official maintainer of the OmniVersion support so a patch would be welcome :) The OmniVersion test suite is part of the automated test. See class org.eclipse.equinox.p2.tests.AutomatedTests
Created attachment 123477 [details] Fix of error in VersionRange intersect causing NPE
Created attachment 123478 [details] Inclusion of intersect test, and fix of issue with one of its tests
(In reply to comment #2) > You are the official maintainer of the OmniVersion support so a patch would be > welcome :) Patches attached. > The OmniVersion test suite is part of the automated test. See class > org.eclipse.equinox.p2.tests.AutomatedTests > Yes, I added it there, but IntersectTest was not included in OmniVersion AllTests. The patch fixes this oversight.
hm - the VersionRange still has bad line endings - the patch is just one long line.... Can a comitter please fix this before I make another (functioning) patch?
Could you please attach the full copy of the class as we still have this encoding issue. I'll look into this though I'm not sure where to look (if you have hints, lmk)
Assigning to me just to make sure I don't forget about it.
Created attachment 123503 [details] Patched VersionRange.java (with correct encoding) (In reply to comment #7) > Could you please attach the full copy of the class as we still have this > encoding issue. I'll look into this though I'm not sure where to look (if you > have hints, lmk) > You need to replace the content of the file by other means then pasting new content into the Eclipse IDE editor since it will preserve the old encoding. Here's how I'd do it: See to that the file is not opened in your IDE. From a shell, Use od -c on the file. Verify that it has the old format (you will see a lot of \r in it). Use cp to copy the new file onto the old one. Use od -c on the file again. No \r should exist. They are all replaced by \n. Refresh your workspace and commit the file.
Changes released in HEAD.
Comment on attachment 123503 [details] Patched VersionRange.java (with correct encoding) Note that the actual patch looks large, because of technical pb with the encoding of teh file in the repo, but the code contribution is actually quite small
