Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 262050 - Unclear directions in New Java Project wizard
Summary: Unclear directions in New Java Project wizard
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-22 12:15 EST by Old Hamlet CLA
Modified: 2009-10-27 04:12 EDT (History)
3 users (show)

See Also:


Attachments
Picture of location section (10.97 KB, image/png)
2009-04-27 08:40 EDT, Dani Megert CLA
no flags Details
patch (10.09 KB, patch)
2009-10-22 03:33 EDT, Deepak Azad CLA
daniel_megert: review-
Details | Diff
reworked patch (12.57 KB, patch)
2009-10-22 23:23 EDT, Deepak Azad CLA
daniel_megert: iplog+
daniel_megert: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Old Hamlet CLA 2009-01-22 12:15:36 EST
Build ID: I20080617-2000

Steps To Reproduce:
1. File->New->Java Project.
2. In the first panel, in the frame entitled "Contents", the option "Create project from existing source" should be renamed to "Create project files in specific directory."

More information:
I am suggesting this change because the new text more closely matches the function of this item: the project files are put in the selected directory, and code can be linked in from any location regardless of where the project files are.  You are not actually bound to put the source in the same directory as the project files.
Comment 1 Dani Megert CLA 2009-01-23 03:06:05 EST
>Create project files in specific directory."
This is one part of it but it also creates a project. I don't like it too much.

Maybe we could change it to
"Create project FOR existing source"
This would better indicate that the source is left where it is.

Markus, what's you take on this?
Comment 2 Markus Keller CLA 2009-01-26 08:02:51 EST
The main intention of the second option is not only to create project files, but to detect existing project files and/or existing source files and to set up the build path accordingly.

Linking in source folders is an advanced operation that can be done on the second page (for both workspace and external projects). "Create project files in specific directory" would make the main intention less clear.
Comment 3 Old Hamlet CLA 2009-01-26 14:03:41 EST
Ah, perhaps this shows my inexperience with Eclipse :-).  Maybe an explanation of my motivations might show why I suggested this.

I was setting up a project in Eclipse to be used by multiple developers via source control--a pretty big first step for someone who's never used the Eclipse before.  Due to our source tree's organization, I had to separate the .project and .classpath files from the main source tree itself.  The only way that I found to do that was to start the project with the "Create project from existing source" option and then specify where I wanted the project files to go before linking in the source.  It was never apparent to me that the "Create project from existing source" option actually builds a project from the source it finds on disk.

If you two think that this is a more advanced usage, then I'm fine with keeping the original text.  It's just that I found the real power of this option to be the fact that it let's you specify where the project files go regardless of where the source is.
Comment 4 Dani Megert CLA 2009-04-27 08:37:15 EDT
Markus and I discussed this again: actually the source is parsed and used for setup in both cases and this is also shown by the info at the bottom of the wizard.

A nice solution is to replace the 'Contents' group with location selection from the simple project wizard (see attached picture).
Comment 5 Dani Megert CLA 2009-04-27 08:40:31 EDT
Created attachment 133343 [details]
Picture of location section
Comment 6 Deepak Azad CLA 2009-10-22 03:33:51 EDT
Created attachment 150205 [details]
patch

Changed the project location selector UI as per the discussion.
Comment 7 Dani Megert CLA 2009-10-22 05:47:58 EDT
The patch does not exactly what I expect: I would expect that the initial section of the wizard looks exactly like the one for a simple project i.e. same labels, mnemonics (if possible without conflicts) and no extra group.

Trivial:
- update copyright when touching a file (NewWizardMessages.java and ref-wizard-
  java-project.htm)
  HINT: ask Raksha for the copyright update save action plug-in which will 
        automatically update the copyright for *.java files on save.
Comment 8 Dani Megert CLA 2009-10-22 05:53:30 EDT
Deepak, please check whether you could easily use org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea. If so, we might want to make that class API.
Comment 9 Deepak Azad CLA 2009-10-22 23:23:52 EDT
Created attachment 150334 [details]
reworked patch

Made the initial section of the new Java project wizard looks exactly like the one for a simple project.

Using org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea was leading to a lot of changes, hence I have not used that.
Comment 10 Dani Megert CLA 2009-10-23 06:08:57 EDT
Patch is good.

Committed to HEAD.
Available in builds > N20091022-2000.
Comment 11 Raksha Vasisht CLA 2009-10-27 04:12:56 EDT
Verified for 3.6 M3 using I20091026-1800.