Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 261506 - [CommonNavigator] NavigatorDNDService seems like it can use only interfaces
Summary: [CommonNavigator] NavigatorDNDService seems like it can use only interfaces
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Linux
: P1 enhancement (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Francis Upton IV CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-19 09:57 EST by Rob Stryker CLA
Modified: 2009-06-03 13:01 EDT (History)
1 user (show)

See Also:

Attachments
small changes (1.58 KB, patch)
2009-01-19 09:59 EST, Rob Stryker CLA 		no flags Details | Diff
CommonDropAdapter has a bad cast (1.41 KB, patch)
2009-01-19 10:17 EST, Rob Stryker CLA 		emoffatt: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Stryker CLA 2009-01-19 09:57:29 EST 
The NavigatorDNDService class seems like it could use only interface APIs and function properly.  Patch attached.
Comment 1 Rob Stryker CLA 2009-01-19 09:59:11 EST 
Created attachment 122939 [details]
small changes
Comment 2 Rob Stryker CLA 2009-01-19 10:17:48 EST 
Created attachment 122944 [details]
CommonDropAdapter has a bad cast

CommonDropAdapter, which is not in an internal package, takes an INavigatorContentService as a parameter, then calls getDnDService() on it, and then casts it from the interface to the private type. The class does not make  use of any private functions, and the class is not an internal class, so this is bad.
Comment 3 Francis Upton IV CLA 2009-01-29 16:54:50 EST 
Patches look good, I will put them in M6
Comment 4 Francis Upton IV CLA 2009-01-31 17:22:55 EST 
Released to HEAD 3.5M6