Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 261460 - [director] structure LatestIUVersionCollector as a query
Summary: [director] structure LatestIUVersionCollector as a query
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M5   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 260214 (view as bug list)
Depends on: 261403
Blocks:
  Show dependency tree
 
Reported: 2009-01-19 02:03 EST by Ian Bull CLA
Modified: 2009-01-22 18:12 EST (History)
2 users (show)

See Also:

Attachments
LatestIUVersionCollector (34.00 KB, patch)
2009-01-19 02:03 EST, Ian Bull CLA 		no flags Details | Diff
Updated Patch (33.56 KB, patch)
2009-01-21 01:47 EST, Ian Bull CLA 		no flags Details | Diff
Updated Patch (35.22 KB, patch)
2009-01-21 14:23 EST, Ian Bull CLA 		jeffmcaffer: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2009-01-19 02:03:00 EST 
Created attachment 122901 [details]
LatestIUVersionCollector

This bug is related to the LatestIUVersionCollector found in the director.

This collector should be structured as a query, taking advantage of the updated query API.

I am attaching a patch (with test cases) that does this.  This has been tested with multiple repos as well as a composite repo (pointing to multiple repos).

This bug depends on Bug 261403.
Comment 1 Ian Bull CLA 2009-01-21 01:47:27 EST 
Created attachment 123169 [details]
Updated Patch

This is an updated patch that converts LatestUIVersionCollector to a Query.  This patch also makes use of the CompoundQueryable to run queries over CompositeRepos and the RepositoryManager.
Comment 2 Ian Bull CLA 2009-01-21 14:23:19 EST 
Created attachment 123278 [details]
Updated Patch

Jeff found a problem with the way progress was being monitored.  this addresses that. (+ a test case)
Comment 3 Jeff McAffer CLA 2009-01-21 14:53:49 EST 
Fix applied to HEAD.  thanks.
Comment 4 Ian Bull CLA 2009-01-22 18:12:59 EST 
*** Bug 260214 has been marked as a duplicate of this bug. ***